Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX! Fix Ivy Failing Test: paddle - elementwise.allclose #28166

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented Feb 3, 2024

PR Description

On 100 numbers of examples it passing locally

allclose-appde

Related Issue

Closes #28165
Closes #28194

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Contributor

@samthakur587 samthakur587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @MuhammadNizamani it looks like all the backend has not support of bfloat16 you can just at assume("bfloat16" not in input_dtype[0]). see if it's works.

@samthakur587
Copy link
Contributor

@with_unsupported_device_and_dtypes(
    {"2.6.0 and below": {"cpu": ("float16",)}},
    backend_version,
)

and

image

@MuhammadNizamani
Copy link
Contributor Author

@samthakur587 new changes are working for all

paddle_allclose new changes

Copy link
Contributor

@samthakur587 samthakur587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@samthakur587 samthakur587 merged commit 2c465d6 into Transpile-AI:main Feb 6, 2024
271 of 281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: jax - elementwise.allclose Fix Ivy Failing Test: paddle - elementwise.allclose
4 participants