Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed paddle_backend.i0 #28184

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

Fix Frontend Failing Test: paddle - pointwise_ops.torch.i0

image

Fix Frontend Failing Test: paddle - exponents_and_logarithms.numpy.i0

image

Related Issue

Closes #28182
Closes #28183

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow all dtypes instead of restricting the test?

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not support
(float16, bfloat16) dtypes because we are using paddle_backend.divide and paddle_backend.subtract in the implementation which do not support those 2 dtypes.

@KareemMAX KareemMAX merged commit 2f2442a into Transpile-AI:main Feb 13, 2024
137 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants