Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undocumented args for torch frontend- added axis support for stack, and value support for scatter_ + extended tests #28252

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

mattbarrett98
Copy link
Contributor

@mattbarrett98 mattbarrett98 commented Feb 12, 2024

This adds support for behaviour which works for native torch i.e. torch.stack allows the dim argument to also be passed using keyword axis, although it isn't in the documentation it does support this and so occasionally pops up in botorch.

…stack`, and `value` support for `scatter_` + extended tests
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Feb 12, 2024
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge the PR, thanks @mattbarrett98 😄

@vedpatwardhan
Copy link
Contributor

Oh sorry, just noticed that test_torch_scatter_ seems to be failing in the CI. Could you please confirm if the failures are related to the changes made? Thanks!

@hmahmood24
Copy link
Contributor

This adds support for behaviour which works for native torch i.e. torch.stack allows the dim argument to also be passed using keyword axis, although it isn't in the documentation it does support this and so occasionally pops up in botorch.

@mattbarrett98 There's a numpy_to_torch_style_args decorator in the torch frontend for this purpose I suppose

@mattbarrett98 mattbarrett98 merged commit c982cc8 into Transpile-AI:main Feb 26, 2024
127 of 140 checks passed
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants