fix: removed code modifying ndarray/torch tensor methods (caused an issue with torch.compile recognising dunder methods). but added the same functionality using __torch_function__/__array_ufunc__ which are the proper mechanisms to enable this behaviour. also simplified the test
#28394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue with torch.compile recognising dunder methods). but added the same functionality using `__torch_function__`/`__array_ufunc__` which are the proper mechanisms to enable this behaviour. also simplified the test
ivy-leaves
added
the
Array API
vedpatwardhan
approved these changes
Feb 26, 2024
Kacper-W-Kozdon
pushed a commit
to Kacper-W-Kozdon/ivy
that referenced
this pull request
Feb 27, 2024
…ssue with torch.compile recognising dunder methods). but added the same functionality using `__torch_function__`/`__array_ufunc__` which are the proper mechanisms to enable this behaviour. also simplified the test (ivy-llc#28394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this code in all the backend init files is very hacky and should be avoided. the torch code specifically was causing an issue with torch.compile so needed to remove this, and also removed for numpy. There were much simpler ways to get the desired behaviour for torch/numpy using
__torch_function/__array_ufunc__, though i don't think the equivalent mechanisms exist in the other frameworks so i have left them for now