Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed un-necessary workflows #28449

Merged

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

Removed un-necessary workflows.

Related Issue

Closes #28447

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Feb 28, 2024
@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Feb 28, 2024

Hey, @vedpatwardhan. I removed all the workflows that I think are not useful now. I'm not 100% sure about the following 5, but I removed them, so please let me know your opinion on these.

  1. label_discussion_comment.yml
  2. manual-tests.yml
  3. manual-tests-pr.yml
  4. run-failing-tests.yml
  5. test-ivy-cron-gpu.yml

Thank you.

Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @vedpatwardhan. I removed all the workflows that I think are not useful now. I'm not 100% sure about the following 5, but I removed them, so please let me know your opinion on these.

  1. label_discussion_comment.yml
  2. manual-tests.yml
  3. manual-tests-pr.yml
  4. run-failing-tests.yml
  5. test-ivy-cron-gpu.yml

Thank you.

Along with these 5, there's a few more that I've flagged that should be retained, rest can be removed. Thanks @Sai-Suraj-27 😄

@@ -1,34 +0,0 @@
name: github-release
on:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow should be retained

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍🏻

@@ -1,32 +0,0 @@
name: pypi
on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workflow should be retained

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍🏻

Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge the PR, thanks @Sai-Suraj-27 😄

@Sai-Suraj-27 Sai-Suraj-27 merged commit d8645a9 into ivy-llc:main Mar 1, 2024
267 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the unnecessary github actions workflows
4 participants