Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add frontend jax.numpy.fft.ifftn #28550

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

Medo072
Copy link
Contributor

@Medo072 Medo072 commented Mar 11, 2024

PR Description

Related Issue

Closes #28549

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Medo072 Medo072 changed the title Add frontend jax.numpy.fft.ifftn feat: Add frontend jax.numpy.fft.ifftn Mar 11, 2024
@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Mar 11, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Medo072
Thank you very much for the PR.
Currently the test_jax_numpy_ifftn seems to fail with torch and numpy backends. You can check the ci logs here https://github.com/unifyai/ivy/actions/runs/8235689979/job/22521391264?pr=28550 under combined test result by searching for test_jax_numpy_ifftn. Alternatively you can run the tests locally with --backend torch and --num-examples 200 to catch the failures. Hope that helps. Let me know if something is unclear. :)

@Medo072
Copy link
Contributor Author

Medo072 commented Mar 17, 2024

there was an issue in the _x_and_ifftn function in test_layers.py as Jax only accept axes of max size = 3 but the function doesn't handle this case, so, I added a new function to handle this case in test_layers.py.

@Medo072 Medo072 requested a review from Ishticode March 17, 2024 15:36
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and passing the test. Thank you very much @Medo072 for the effort put in this contribution :)

@Ishticode Ishticode merged commit a3146df into ivy-llc:main Mar 23, 2024
216 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jax.numpy.fft.ifftn
3 participants