Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: paddle - tensor.torch.Tensor.fix #28611

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 15, 2024

PR Description

Some dtypes aren't supported according to the logs, updated the supported dtype handle.
tensor fix

Related Issue

Close #28604
Close #28605

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Mar 15, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZJay07
Thank you very much for the contribution. As this is an issue with paddle backend not being able to handle certain dtypes, it should be specified in the specific ivy function for it is not supported in paddle backend no torch frotnend as native torch itself is able to support uint8 for fix for example. Does that make sense?

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 21, 2024

Hey @Ishticode thanks for the feedback! Just updated the fix, not sure if it's the right way to fix it base on paddle specific failures.

@ZJay07 ZJay07 requested a review from Ishticode March 21, 2024 19:41
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank @ZJay07

@Ishticode Ishticode merged commit ea40261 into ivy-llc:main Mar 25, 2024
136 of 141 checks passed
@ZJay07 ZJay07 deleted the fixing-test-8 branch March 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Paddle Backend PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants