Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ASan on CI bulds #2011

Closed
ericwa opened this issue Feb 4, 2018 · 1 comment
Closed

Use ASan on CI bulds #2011

ericwa opened this issue Feb 4, 2018 · 1 comment
Assignees
@ericwa
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Enhancement New features
Milestone
TrenchBroom 2.0.0

Comments

@ericwa
Copy link
Collaborator

ericwa commented Feb 4, 2018

I'm pretty sure AddressSanatizer would have caught: #2008

Maybe check if CI is building a tag, and omit ASan in those cases so we don't ship it with releases.
@ericwa ericwa mentioned this issue Feb 4, 2018
Merged
@ghost ghost assigned ericwa Feb 4, 2018
@ghost ghost added the Status:In Progress label Feb 4, 2018
@kduske
Copy link
Collaborator

kduske commented Feb 4, 2018

Yes, more checks are definitely a good idea.

@kduske kduske added Type:Enhancement New features Platform:All Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Feb 4, 2018
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Feb 4, 2018
@ericwa ericwa closed this as completed Feb 5, 2018
@ghost ghost removed the Status:In Progress label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwa ericwa

Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Enhancement New features
Projects
None yet
Milestone
TrenchBroom 2.0.0
Development

No branches or pull requests
2 participants
@kduske @ericwa