Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrenchBroom Manual should have an interactive and sticky TOC #2421

Closed
jonathanlinat opened this issue Nov 3, 2018 · 3 comments · Fixed by #2760
Closed

TrenchBroom Manual should have an interactive and sticky TOC #2421

jonathanlinat opened this issue Nov 3, 2018 · 3 comments · Fixed by #2760
Assignees
@jonathanlinat
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features
Milestone
2.1.0

Comments

@jonathanlinat
Copy link
Contributor

System Information

TrenchBroom V2.1.0

Expected Behavior

On small or mobile devices, the TOC section should be:

  • Hidden
  • Only collapsable/expandable clicking on a button
  • Sticky
  • With accessible content using a vertical scroll

Thank you very much!
@kduske kduske added this to the 2.1.0 milestone Nov 3, 2018
@kduske kduske added Type:Enhancement New features Prio:3 Low priority: Minor problems and nice to have features labels Nov 3, 2018
@kduske kduske added the Area:UI label Nov 4, 2018
@jonathanlinat
Copy link
Contributor Author

2018-11-13_18-38-08

At this moment, I have implemented the sticky Table of Content on desktop view.

@jonathanlinat
Copy link
Contributor Author

trenchbroom_manual_mobileversion
trenchbroom_manual_mobilevsdesktopversion
Done!

@jonathanlinat jonathanlinat mentioned this issue May 12, 2019
Merged
@ericwa
Copy link
Collaborator

ericwa commented May 15, 2019

The TOC is cut off on Edge. I don't use it but just thought I would mention it: (Microsoft Edge 44.17763.1.0)
Capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanlinat jonathanlinat

Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

2421: TOC is now interactive, responsive and sticky.
3 participants
@kduske @ericwa @jonathanlinat