Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader parser cannot parse blendFunc correctly #2568

Closed
leilei- opened this issue Feb 4, 2019 · 2 comments
Closed

Shader parser cannot parse blendFunc correctly #2568

leilei- opened this issue Feb 4, 2019 · 2 comments
Assignees
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Milestone

Comments

@leilei-
Copy link

leilei- commented Feb 4, 2019

System Information

TrenchBroom 2019.2 on Windows

Expected Behavior

The shader to be parsed and load as selectable textures.

Steps to Reproduce

With the Quake3 configuration, add textures/sfx. Shaders such as sfx/beam_waterlight2 will not show up because of textures/sfx/glass carrying GL_ONE_MINUS_SRC_ALPHA in its blendFunc function, for one example.

Crash Info

No crash

@kduske kduske added Type:Bug Errors and problems Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working labels Feb 4, 2019
@kduske kduske added this to the 2019.3 milestone Feb 4, 2019
@ghost ghost assigned kduske Feb 4, 2019
@ghost ghost added the Status:In Progress label Feb 4, 2019
@ghost ghost removed the Status:In Progress label Feb 4, 2019
@ericwa ericwa reopened this Feb 5, 2019
@ericwa
Copy link
Collaborator

ericwa commented Feb 5, 2019

f3cf093 still can't load the textures\sfx texture collection from a vanilla Q3 installation:

Added texture collection textures\sfx
Could not load texture collection 'textures\sfx': Unknown GL enum: GL_one
  • These should be case insensitive.
  • An unrecognized blend mode shouldn't stop the whole texture collection from loading. The shader itself should still load too, just with a warning
  • Typo: DEST should be DST in GL_ONE_MINUS_DEST_COLOR

Some of the enum values supported by Q3 are missing, see: https://github.com/id-Software/Quake-III-Arena/blob/master/code/renderer/tr_shader.c#L176

@kduske
Copy link
Collaborator

kduske commented Feb 5, 2019

Okay I'll revise this, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Projects
None yet
Development

No branches or pull requests

3 participants