Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture filename filter support #2702

Closed
IceReaper opened this issue Apr 4, 2019 · 3 comments · Fixed by #2944
Closed

Texture filename filter support #2702

IceReaper opened this issue Apr 4, 2019 · 3 comments · Fixed by #2944
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features

Comments

@IceReaper
Copy link

This is not a bug, but a feature request. Im currently using TrenchBroom for a custom engine which has its own file and folder setup. Textures lie as .png files in the textures folder. While this loads up perfectly in Trenchbroom, it also loads the additional maps. Hence i would love to see a file suffix or pattern filter implemented :)
My setup:

texture_Ambient_Occlusion.png
texture_Base_Color.png << I only want to load and show this ones in TrenchBroom, and i also want to store the name without the suffix in the .map, so just "texture" in this example
texture_Height.png
texture_Normal.png
texture_Roughness.png

Speaking of the setup: I do not need the textures themself to be embeded in the final map, just referenced (im targeting on loading the TrenchBroom .map format directly). So is there any way to make the whole textures folder (including the folder itself, not just subfolders) available in TrenchBroom? That would also make the "_tb_textures" property obsolete ofcourse.

@kduske
Copy link
Collaborator

kduske commented Apr 4, 2019

I will have to think about this for a bit. It may be that we need to extend TB's way of scanning for and organizing textures anyway.

Here's another related issue: #2452.

@ericwa any thoughts?

@kduske kduske added Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features labels Apr 4, 2019
@ericwa
Copy link
Collaborator

ericwa commented Apr 5, 2019

For excluding normal maps etc., one idea could be supporting glob patterns for excluding textures in the game config, like:
"excludes" : ["*_Ambient_Occlusion.png", "*_Height.png", "*_Normal.png"]
This should be pretty easy to implement.

So is there any way to make the whole textures folder (including the folder itself, not just subfolders) available in TrenchBroom?

I'd be in favour of having this as well. Not sure exactly how it would work but some way of browsing all textures in the search path without having to whitelist individual subdirectories would be nice. (Probably wouldn't make sense for Q1 wads, but only for games that use directory texture collections)

@kristus
Copy link

kristus commented Dec 26, 2019

anything that lets the developer of a configuration set up their own filters is fantastic really. But what Ericwa said I am fully aboard with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants