Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Hamburger" icon doesn't collapse the manual's TOC on mobile screen size #3736

Closed
neogeographica opened this issue Feb 15, 2021 · 2 comments · Fixed by #3737
Closed

"Hamburger" icon doesn't collapse the manual's TOC on mobile screen size #3736

neogeographica opened this issue Feb 15, 2021 · 2 comments · Fixed by #3737
Assignees
@jonathanlinat
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Maintenance Non-functional changes that improve code quality or the build system
Milestone
2022.1

Comments

@neogeographica
Copy link
Contributor

This is with the current online manual (2021.1); I haven't checked the local manual's behavior yet. Using Chrome 88.0.4324.150 on macOS.

If the browser window is narrow enough, the TOC collapses to the left. I can use the "hamburger" icon in top-left to expand it. So far so good.

However, I would expect that I could click the hamburger again to collapse it, but that does nothing.

A couple of other observations:

  • Clicking on a TOC item takes me to that spot in the manual and collapses the TOC... that all seems good.

  • Clicking on the "Back to top" icon in the bottom-left collapses the TOC. That seems a little odd; I'm not 100% sure what that icon is supposed to do but I would have guessed that it would just scroll me back to the top of the TOC without collapsing it.
@ericwa
Copy link
Collaborator

ericwa commented Feb 15, 2021

Yeah, I noticed this as well - this is a byproduct of the way opening the TOC is implemented by navigating to the #toc anchor. AFAIK the only way to close the TOC with the current implementation would be to trigger the back button with JS.

It might be better to not affect your URL / page scroll position when you open the TOC, and just have it appear with JS?

@ericwa ericwa added Prio:3 Low priority: Minor problems and nice to have features Type:Maintenance Non-functional changes that improve code quality or the build system labels Feb 15, 2021
@ericwa ericwa changed the title "Hamburger" icon doesn't collapse the TOC "Hamburger" icon doesn't collapse the manual's TOC on mobile screen size Feb 15, 2021
@ericwa ericwa assigned ericwa and unassigned ericwa Feb 15, 2021
@jonathanlinat
Copy link
Contributor

jonathanlinat commented Feb 15, 2021 •
edited

I'm working on fixing that issue. Thanks @neogeographica

@jonathanlinat jonathanlinat mentioned this issue Feb 15, 2021
Merged
@kduske kduske added this to the 2022.2 milestone May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanlinat jonathanlinat

Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Maintenance Non-functional changes that improve code quality or the build system
Projects
None yet
Milestone
2022.1
Development

Successfully merging a pull request may close this issue.

3736: "Hamburger" icon doesn't collapse the manual's TOC on mobile screen size
4 participants
@kduske @ericwa @neogeographica @jonathanlinat