Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate type of asset (e.g. FGD) that fails to parse when loading map fails #4457

Open
4LT opened this issue Jan 26, 2024 · 3 comments
Open

Indicate type of asset (e.g. FGD) that fails to parse when loading map fails #4457

4LT opened this issue Jan 26, 2024 · 3 comments
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features

Comments

@4LT
Copy link

4LT commented Jan 26, 2024 •
edited
Loading

Map fails to open, instead showing an error that there is a "=" token where end of file would be expected.

System Information

TrenchBroom 2024.1 RC1

Arch Linux

Steps to Reproduce

  1. Launch TrenchBroom
  2. Open file (provided)

screen_222
waterfall.map.zip

Lines 61-63:

( -176 -128 -48 ) ( -175 -128 -48 ) ( -176 -127 -48 ) uwall1_2 [ -1 0 0 -48 ] [ 0 -1 0 0 ] 0 1 1
( -128 128 320 ) ( -128 129 320 ) ( -127 128 320 ) uwall1_2 [ 1 0 0 48 ] [ 0 -1 0 0 ] 0 1 1
( -128 128 -40 ) ( -127 128 -40 ) ( -128 128 -39 ) uwall1_2 [ -1 0 0 -48 ] [ 0 0 -1 0 ] 0 1 1
@4LT
Copy link
Author

4LT commented Jan 26, 2024 •
edited
Loading

Ah, it's not associated with the map but the FGD. The FGD I have does indeed have extraneous '=' tokens.

Leaving this open, because the error could be more descriptive of cause.

@4LT 4LT changed the title [Bug] Fails to open map w/ error "Unexpected '='" when there is no such character in file [Feature] Indicate type of asset (e.g. FGD) that fails to parse when loading map fails Jan 26, 2024
@kduske
Copy link
Collaborator

kduske commented Jan 26, 2024

Please stop adding prefixes like "[Feature]", these are useless to me. Thanks!

@kduske kduske changed the title [Feature] Indicate type of asset (e.g. FGD) that fails to parse when loading map fails Indicate type of asset (e.g. FGD) that fails to parse when loading map fails Jan 26, 2024
@kduske kduske added Type:Enhancement New features Prio:3 Low priority: Minor problems and nice to have features labels Jan 26, 2024
@4LT
Copy link
Author

4LT commented Jan 26, 2024

Sorry, force of habit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Prio:3 Low priority: Minor problems and nice to have features Type:Enhancement New features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kduske @4LT