Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/analytics logger #26

Merged
merged 22 commits into from
Feb 4, 2022
Merged

Feature/analytics logger #26

merged 22 commits into from
Feb 4, 2022

Conversation

ibrahimsn98
Copy link
Contributor

@ibrahimsn98 ibrahimsn98 commented Jan 31, 2022 •
edited

A devTools module to inspect sent analytics events.

Usage:

AnalyticsLogger.init(this)

 AnalyticsLogger.report(
      key = "OnMainFragmentSeenEvent",
      value = EventModel("TestAction", "TestCategory", "TestScreen"),
      platform = EventPlatform.FIREBASE,
  )

Screenshots:
Screenshot_1643628048
image
image

bilgehankalkan
bilgehankalkan reviewed Feb 4, 2022
View reviewed changes
analytics-logger-no-op/build.gradle Outdated Show resolved Hide resolved
analytics-logger-no-op/publish.gradle Outdated Show resolved Hide resolved
...va/com/trendyol/android/devtools/analyticslogger/internal/data/repository/EventRepository.kt

import com.trendyol.android.devtools.analyticslogger.internal.data.model.EventEntity

internal interface EventRepository {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of using interface for repository?

...src/main/java/com/trendyol/android/devtools/analyticslogger/internal/factory/ColorFactory.kt
"#3222A6B3",
)

fun getColor(value: String): Int {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

...logger/src/main/java/com/trendyol/android/devtools/analyticslogger/internal/ext/StringExt.kt

import com.squareup.moshi.Moshi

internal fun String?.beautify(moshi: Moshi): String? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this Moshi can be provided from AnalyticsContainer via static instance.

@ibrahimsn98 ibrahimsn98 merged commit 7ace7d3 into develop Feb 4, 2022
@ibrahimsn98 ibrahimsn98 deleted the feature/analytics-logger branch February 23, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgehankalkan bilgehankalkan bilgehankalkan left review comments

@mucahidkambur mucahidkambur mucahidkambur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibrahimsn98 @bilgehankalkan @mucahidkambur