Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker Component #143

Open
Tracked by #64
muratcorlu opened this issue Jun 27, 2022 · 2 comments
Open
Tracked by #64

Date Picker Component #143

muratcorlu opened this issue Jun 27, 2022 · 2 comments
Labels
ADR-required An Architectural Design Record is needed for this issue component Component development related issues

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Jun 27, 2022

Figma

TBD

@muratcorlu muratcorlu mentioned this issue Jun 27, 2022
64 tasks
@muratcorlu muratcorlu added this to the v2.0 milestone Jun 28, 2022
@muratcorlu muratcorlu added the needs clarification Issues that needs more complete description label Jul 26, 2022
@sinandinar
Copy link
Contributor

Period selections can be defined. Daily, weekly, monthly and yearly.

CleanShot 2022-09-19 at 11 13 40@2x

The ability to switch from one to the other in the period selections in connection with the selected date. For example, when 16 august is selected in the daily selection, when I switch to the weekly, the week that includes 16 august must be selected.

CleanShot 2022-09-19 at 11 16 45@2x

CleanShot 2022-09-19 at 11 17 38@2x

Custom shortcuts can be defined. e.g. last 30 days, last 7 days, yesterday, today.

CleanShot 2022-09-19 at 11 19 03@2x

Free range selection can be defined.

CleanShot 2022-09-19 at 11 19 47@2x

@muratcorlu muratcorlu added ADR-required An Architectural Design Record is needed for this issue and removed baklava-ds labels Dec 12, 2022
@muratcorlu muratcorlu removed this from the v2.0 milestone Feb 9, 2023
@muratcorlu
Copy link
Contributor Author

I wanted to note down some of my observations and ideas about this component:

  1. Firstly we need to have a “calendar” component that will render monthly calendar view and can be used inside data picker component as well as any other place tho shouw a calendar that some events attached to it.
  2. Day and Month names should be localized but this can be done automatically by native Intl API.
  3. Other labels like “Month”, “Week”, “Last 7 days” etc should be done by localization support. So maybe we can prioritze Localization support #398 first.

There is also a good/fresh article about A11Y and I18N of a calendar UI, we can make use of: https://css-tricks.com/making-calendars-with-accessibility-and-internationalization-in-mind/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR-required An Architectural Design Record is needed for this issue component Component development related issues
Projects
Status: ADR In Progress
Development

No branches or pull requests

2 participants