Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select component #225

Merged
merged 17 commits into from
Sep 26, 2022
Merged

feat: select component #225

merged 17 commits into from
Sep 26, 2022

Conversation

mustafafrw
Copy link
Contributor

@mustafafrw mustafafrw commented Sep 8, 2022 •
edited

This PR is for a new component: Select

Contains following features

  • bl-select component
  • bl-select-option component
  • Storybook files
  • Unit tests

Update: bl-checkbox component added into bl-select-option

muratcorlu
muratcorlu reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mustafafrw!

Some parts are more complicated than I expected. I shared my partial review notes. I will continue soon about other parts.

src/components/select/bl-select.css Outdated Show resolved Hide resolved
src/components/select/bl-select.ts Outdated Show resolved Hide resolved
src/components/select/bl-select.ts Outdated Show resolved Hide resolved
src/components/select/bl-select.ts Outdated Show resolved Hide resolved
src/components/select/bl-select.ts Outdated Show resolved Hide resolved
src/components/select/bl-select.ts Outdated Show resolved Hide resolved
src/components/select/option/bl-select-option.ts Outdated Show resolved Hide resolved
src/components/select/option/bl-select-option.ts Outdated Show resolved Hide resolved
src/components/select/option/bl-select-option.ts Outdated Show resolved Hide resolved
@muratcorlu
Copy link
Contributor

We are suffering with linter errors in every PRs. There is something wrong on our linter configuration for sure. We really need to look at it deeply @leventozen :(

@leventozen
Copy link
Member

leventozen commented Sep 12, 2022 •
edited

We are suffering with linter errors in every PRs. There is something wrong on our linter configuration for sure. We really need to look at it deeply @leventozen :(

😕 today, I will work on it. I think I found out what is the issue there.

muratcorlu
muratcorlu reviewed Sep 13, 2022
View reviewed changes
src/components/select/bl-select.css Outdated Show resolved Hide resolved
src/components/select/option/bl-select-option.css Outdated Show resolved Hide resolved
src/components/select/bl-select.css Outdated Show resolved Hide resolved
@buseselvi
Copy link
Contributor

Can we fix the Disabled SelectOption color to Content Passive (#AFBBCA) color? @mustafafrw

@mustafafrw
Copy link
Contributor Author

mustafafrw commented Sep 14, 2022 •
edited

Can we fix the Disabled SelectOption color to Content Passive (#AFBBCA) color? @mustafafrw

Done 🚀

@buseselvi
Copy link
Contributor

Can we also fix the Disabled Selected Option color to Content Passive (#AFBBCA) color? 🙏🏻 @mustafafrw
image

@mustafafrw
Copy link
Contributor Author

mustafafrw commented Sep 19, 2022 •
edited

Can we also fix the Disabled Selected Option color to Content Passive (#AFBBCA) color? 🙏🏻 @mustafafrw image

Done 🚀

Also,

  • Stories has been edited.
  • Slot control in Canvas tab is deleted.
  • Flip state of select menu can be seen in Select Labels canvas.

muratcorlu
muratcorlu approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mustafafrw!

I think currently only big missing part is using select as a form field. We'll need ElementInternals integration with name and value attributes, but I think it's ok to merge this for now and track that part in a separate issue. @leventozen, does it make sense to you, too?

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@leventozen leventozen merged commit e65cb90 into next Sep 26, 2022
@leventozen leventozen deleted the 88-select-component branch September 26, 2022 10:52
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@muratcorlu muratcorlu mentioned this pull request Sep 26, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventozen leventozen leventozen left review comments

@muratcorlu muratcorlu muratcorlu approved these changes

@buseselvi buseselvi buseselvi approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mustafafrw @muratcorlu @leventozen @buseselvi