Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Component #239

Closed
Tracked by #64
leventozen opened this issue Sep 19, 2022 · 3 comments · Fixed by #333
Closed
Tracked by #64

Dropdown Component #239

leventozen opened this issue Sep 19, 2022 · 3 comments · Fixed by #333
Assignees
@leventozen
Labels
component Component development related issues released on @beta released

Comments

@leventozen
Copy link
Member

leventozen commented Sep 19, 2022 •
edited

Figma
@leventozen leventozen mentioned this issue Sep 19, 2022
Closed
64 tasks
@leventozen leventozen added baklava-ds component Component development related issues needs clarification Issues that needs more complete description labels Sep 19, 2022
@muratcorlu
Copy link
Contributor

muratcorlu commented Sep 30, 2022 •
edited

Dropdown Component Design Meeting Report

Date: 28.09.2022 15:30 (UTC+3)

  • The purpose of Dropdown Component is to provide a way to trigger an action from a list. It's not an input field. For input cases select component will be used.
  • We'll need an enhancement on the button component to have a "dropdown button" version (with a caret at right and active state to change it to open/closed states.
  • Dropdown items will be an internal component (dropdown item) that contains only the tertiary button.
  • Grouping of some items with an optional caption will be possible.
  • Width of the popover of the dropdown will be minimum at the same as of the trigger, but it can be wider regarding to action button widths inside.
  • There will be no scroll on the action list unless it hits the boundary of the viewport height. So max-height will be available viewport height.
  • Dropdown will be in 3 sizes as our buttons have.

Design work will start according to those decisions then implementation will be planned.

@leventozen leventozen self-assigned this Oct 25, 2022
@leventozen leventozen mentioned this issue Dec 6, 2022
Merged
@leventozen leventozen removed the needs clarification Issues that needs more complete description label Dec 7, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0-beta.52 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leventozen leventozen

Labels
component Component development related issues released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dropdown component Trendyol/baklava
2 participants
@muratcorlu @leventozen