Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baklava identifies itself as Unknown in React #397

Closed
Enes5519 opened this issue Feb 2, 2023 · 6 comments · Fixed by #449
Closed

Baklava identifies itself as Unknown in React #397

Enes5519 opened this issue Feb 2, 2023 · 6 comments · Fixed by #449
Labels
react Issues related with React wrapper released on @beta released

Comments

@Enes5519
Copy link
Contributor

Enes5519 commented Feb 2, 2023

Describe the bug
Baklava not work in React 16. It identifies itself as "Unknown" component.
Possible: React Lazy Exports

To Reproduce

  1. Upgrade baklava version to 2.0.0-beta.59 from 2.0.0-beta.48

Screenshots
Screen Shot 2023-02-02 at 11 01 12

Desktop (please complete the following information):

  • OS: Mac
  • Browser [e.g. chrome, safari]: Firefox
  • Version [e.g. 22]: 59
@muratcorlu
Copy link
Contributor

muratcorlu commented Feb 2, 2023

Hi @Enes5519,

Thank you for the report.

For confirmation: You use the same version on both CDN and NPM, right?

@olkeoguz
Copy link
Contributor

olkeoguz commented Feb 3, 2023

@muratcorlu With the release of lazily loading baklava components (#320), we were expecting baklava not to work in React 16 and some versions of 17 since they handle React Lazy differently. We don't have any issues with the 18 though.

@muratcorlu muratcorlu added the react Issues related with React wrapper label Feb 7, 2023
@muratcorlu
Copy link
Contributor

I'm trying to debug this. I created a demo with React 16 and TS and apparently managed to run Baklava (beta75) in it without any issues. @Enes5519 can you check this: https://codesandbox.io/s/baklava-in-react-16-ts-ninfd0?file=/src/index.tsx

I feel there is a problem about either TS version or tsconfig.

@muratcorlu
Copy link
Contributor

Can you check if #449 fixes the issue here?

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

🎉 This issue has been resolved in version 2.0.0-beta.77 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react Issues related with React wrapper released on @beta released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants