Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add localization #787

Merged
merged 6 commits into from
Feb 5, 2024
Merged

feat: add localization #787

merged 6 commits into from
Feb 5, 2024

Conversation

AykutSarac
Copy link
Member

@AykutSarac AykutSarac commented Jan 29, 2024 •
edited by leventozen

  • Uses @lit/localize-tools and @lit/localize
  • This adds localization support for Lit components.
  • Added storybook document.
  • Listens for html element's lang attribute with mutation observer.
  • Not initialized by default, instructions added to storybook.
  • Output mode is set to runtime, meaning that it has to be capable of changing runtime by rerendering components.
  • Added localization support for:
    • Select
    • Pagination

Closes #398

erbilnas
erbilnas reviewed Jan 30, 2024
View reviewed changes
playground/template.html Outdated Show resolved Hide resolved
src/generated/locales/tr-TR.ts Outdated Show resolved Hide resolved
@AykutSarac AykutSarac marked this pull request as ready for review January 30, 2024 12:22
@leventozen leventozen self-requested a review February 1, 2024 08:10
@leventozen leventozen merged commit 7a6cea3 into next Feb 5, 2024
7 checks passed
@leventozen leventozen deleted the feat/i18n branch February 5, 2024 08:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erbilnas erbilnas erbilnas left review comments

@leventozen leventozen leventozen approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localization support
3 participants
@AykutSarac @leventozen @erbilnas