Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split-button component #814

Merged

Conversation

MehmetCanBOZ
Copy link
Contributor

Split button component completed.

Closes #264

commitlint.config.cjs Outdated Show resolved Hide resolved
Copy link
Member

@leventozen leventozen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@buseselvi
Copy link
Contributor

Great! 🚀 I have a few notes:

  1. Can we fix the focused state border radiuses like in the design (second image)
image image
  1. I am not sure but in the disabled state, the border line color looks darker than the text and arrow color, they should have the same colors. Can we check? 🙏
image

@MehmetCanBOZ MehmetCanBOZ force-pushed the 264-feat-split-button-component branch from 251e2d5 to e317bde Compare March 26, 2024 06:39
@MehmetCanBOZ
Copy link
Contributor Author

MehmetCanBOZ commented Mar 26, 2024

Thanks @buseselvi , I fixed the focused state border radiuses and changed the bg-color of split-divider on disabled state like in the design.

@MehmetCanBOZ MehmetCanBOZ force-pushed the 264-feat-split-button-component branch from e317bde to 134e063 Compare March 26, 2024 07:31
fix: commitlint scope enum

fix: focused state border-radius and split-divider bg color on disabled

fix: storybook folder type issue

fix: focused state border-radiuses and add example of main button strech
@MehmetCanBOZ MehmetCanBOZ force-pushed the 264-feat-split-button-component branch from 134e063 to ca87540 Compare March 26, 2024 09:50
@leventozen leventozen merged commit ca06fb6 into Trendyol:next Mar 29, 2024
5 checks passed
Copy link

🎉 This PR is included in version 3.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Button Component
4 participants