feat: 178 v distance to #220
Conversation
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@andretchen0 I know if a lot to see, but if you find time, without rush please check this too Also, if you have a better solution of how to show the distance will be appreciated, I'll just console.log it, because create a 3D text will be too much |
There was a problem hiding this comment.
Works as advertised. 👍
There a couple language changes to make in the docs. Nothing major.
Otherwise, I made some suggestions:
- Based on the comments in the code, you were looking for a way to incorporate other displays. I made a suggestion for the API, but feel free to implement or not.
- Currently, passing a null ref to
v-distance-tothrows an unhandled error. With Vue, a lot of times it's easier to start with a null ref in the setup. So, I'd prefer to have a guard in this component to do some type checking, then either fail silently orconsole.warnif the ref isn't an object with a position. But it's your call.
|
If I was better with Typescript I could definitely do something better, but for now I'll validate manually :D I appreciate this feedbacks |
|
@andretchen0 I'll be on vacations from 14 - oct, to 04 nov So I'll not make more PRs for now, please take care of cientos 🙏 |
Sounds good. See you in november! |
|
@andretchen0 Hey there! Thanks for taking care of reviewing, what do you think, ready to merge? |
It's ready to go, I believe. |
closes #178