Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links matching regexp / plain text #21

Open
andsofine opened this issue Jun 20, 2022 · 8 comments
Open

Open links matching regexp / plain text #21

andsofine opened this issue Jun 20, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@andsofine
Copy link

add a list of trusted links.
and the ability to add them yourself

@TrianguloY
Copy link
Owner

What do you exactly mean by trusted links? Links that will open the app directly without any interaction?

@andsofine
Copy link
Author

What do you exactly mean by trusted links? Links that will open the app directly without any interaction?

yep

@TrianguloY
Copy link
Owner

Is #18 what you want?

@andsofine
Copy link
Author

Is #18 what you want?

as far as I understand he/she said that the default apps should be opened immediately.

but sometimes you need to constantly open some site that does not have an app (and you already know it's safe). and this is where trusted links are needed

@TrianguloY
Copy link
Owner

Ah ok, so rather that "if app can open link" -> open that app, do "if link matches this" -> open in app.

That's ok for a new issue.

@TrianguloY TrianguloY added the enhancement New feature or request label Jun 28, 2022
@TrianguloY TrianguloY changed the title trusted Open links matching regexp / plain text Jun 28, 2022
@andsofine
Copy link
Author

Ah ok, so rather that "if app can open link" -> open that app, do "if link matches this" -> open in app.

That's ok for a new issue.

I now understood that it is better to issue it as "configure urls"
I will explain in more detail.
so, apps and just urls will be configured differently

for an example with apps, let's take the youtube app.
it will be possible to choose to open via: "url checker", "youtube app", "browser"
I don’t know if there is a need for the ability to configure modules when it comes to apps

for just urls created in the url checker (or maybe also make a small list of default ones) there will be such options (for each separately):

immediately redirect to the browser (toggle)
(this is what I mean by trusted)

and modules settings (all modules added here should be auto-applyable so they make sense when "immediately redirect to the browser" is enabled too) such as
"Clear url", "Status code" etc.

and probably need to be done so that if the user installed an app suitable for any of the added links, this would not be a problem (or vice versa if the user deleted the app)

@Efreak
Copy link

Efreak commented May 2, 2023

If implemented, this should remember the immediately previous opened. If the new item is the same, pop the UI regardless of settings; if I'm opening a URL twice in a short time period, there's probably something wrong, and it's a good indication that I might want to change settings for the URL, or I might want to open it in a different app just this once. (Open in app defaults to redreader, but I want to open it in the browser because I want to see the page CSS or some such, so tell redreader to open in another app -> the new URL is the same as the old URL so don't just open in redreader, ask me)

@TrianguloY
Copy link
Owner

Hmm, looks useful, something to consider.
But in that case it would work by default, unless you disabled the "hide the source app (referrer)" from the open module settings. With that on, if you open an url from redreader, then redreader will not be available as a choice.

It could also be implemented as rules depending on the referrer (so if you open an url from app X apply this, but if it opens from Y apply that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants