Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify exact dependency requirements #1084

Closed
qstokkink opened this issue Jan 28, 2022 · 2 comments
Closed

Specify exact dependency requirements #1084

qstokkink opened this issue Jan 28, 2022 · 2 comments
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

Our requirements.txt file mostly does not specify what the minimum version is we support for each dependency. We should make this more explicit to avoid preventable failures.

I ran an automated test to check which of the available versions of our dependencies managed to (1) install on my Windows 10 machine and (2) pass our unit tests. The results are as follows (green passed, red failed either step 1 or 2):

requirements

@qstokkink qstokkink added the priority: low Should be addressed at some point in the future label Jan 28, 2022
@qstokkink
Copy link
Collaborator Author

For reference, this is the script I used https://gist.github.com/qstokkink/4e99ff4bc19266b27f7c942dfba3a58d

@qstokkink
Copy link
Collaborator Author

Upon further reflection: when installing the latest version of its dependencies IPv8 should just work. If a dependency becomes a problem (for whatever reason) we can treat the issue on a case-by-case basis (e.g., how we phased out asyntest).

Managing a huge matrix of supported versions is overkill for our project's scope and I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be addressed at some point in the future
Projects
None yet
Development

No branches or pull requests

1 participant