Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between with and without toml configuration file scenario #19

Closed
NOhs opened this issue Mar 31, 2018 · 2 comments
Closed
Labels
discussion Something that might end up being labled enhancement or wontfix

Comments

@NOhs
Copy link
Collaborator

NOhs commented Mar 31, 2018

If a toml file (even a very simple one), sources are expected to be in the src folder. However, without a toml file, clang-build will look directly in the target folder. To me this has several disadvantages:

  • more heterogenious project structures (some with src folder, others just having the source files directly in the top directory
  • restructuring of the project when adding a toml file later, or breaking the default (both are cumbersome)
  • messy code

I also see the advantage that clang-build is more usable for quick tests as no special folder structure is required. However, creating a single 'src' folder is not really effort and so I am not sure how much this point is actually relevant.

@NOhs NOhs added the discussion Something that might end up being labled enhancement or wontfix label Mar 31, 2018
@GPMueller
Copy link
Contributor

For me the main argument is that trivial projects should really be trivial to build. Project structures will always be somewhat heterogeneous and people will choose a build system etc. to suit their taste. As long as we don't have features with the sole purpose of supporting legacy project structures or the different tastes of different people, I think it's fine.

@GPMueller
Copy link
Contributor

Note that also the build directories currently differ for "anonymous" targets (i.e. without build config) and named targets. But I think that's probably unproblematic.

@NOhs NOhs closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Something that might end up being labled enhancement or wontfix
Projects
None yet
Development

No branches or pull requests

2 participants