Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking the readme.rst #28

Closed
NOhs opened this issue Apr 15, 2018 · 6 comments
Closed

Checking the readme.rst #28

NOhs opened this issue Apr 15, 2018 · 6 comments
Labels
documentation Something related to the documentation or readme tests Anything regarding tests

Comments

@NOhs
Copy link
Collaborator

NOhs commented Apr 15, 2018

Since pypi is supposed to nicely render the *.rst file, we have to make sure it is bug-free. For this several tools can be put in the CI scripts, see also this discussion:
https://stackoverflow.com/questions/16367770/my-rst-readme-is-not-formatted-on-pypi-python-org

@NOhs NOhs added the documentation Something related to the documentation or readme label Apr 15, 2018
@NOhs NOhs added this to the Create a documentation milestone Apr 15, 2018
@thautwarm
Copy link
Contributor

FYI, Markdown is now supported in PyPI.

In setup.py, when invoking setup, add a keyword argument long_description_content_type="text/markdown".

@NOhs
Copy link
Collaborator Author

NOhs commented Dec 28, 2018

Good to know. Thanks for the info.

@thautwarm
Copy link
Contributor

@NOhs you're welcome, I'm looking forward to your stable release, that does help!

@thautwarm
Copy link
Contributor

Note that you should use twine to upload the package:

python setup.py bdist_wheel &&
twine upload dist\*

@GPMueller
Copy link
Contributor

A problem has appeared with the deployment to PyPI:

HTTPError: 400 Client Error: The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information. for url: https://upload.pypi.org/legacy/
PyPI upload failed.

It seems related to this pypa issue, where in our case the toml code blocks would be the problem. It is unclear to me how this should be resolved on our side, in particular since it previously worked (i.e. the toml code blocks were rendered correctly).

Installing collective.checkdocs on Travis and running python3 setup.py checkdocs would in this case tell us something like

<string>:194: (WARNING/2) Cannot analyze code. No Pygments lexer found for "toml".
error: long_description had reST syntax errors

@GPMueller GPMueller added the tests Anything regarding tests label May 5, 2020
@GPMueller
Copy link
Contributor

Since b275064 we have a Readme.md instead. As there is a lot less potential for syntactic mistakes there and we will likely not add any test for it, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something related to the documentation or readme tests Anything regarding tests
Projects
None yet
Development

No branches or pull requests

3 participants