Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Eigen copy in repository #40

Closed
NOhs opened this issue May 2, 2018 · 1 comment
Closed

Get rid of Eigen copy in repository #40

NOhs opened this issue May 2, 2018 · 1 comment
Assignees
@NOhs
Labels
discussion Something that might end up being labled enhancement or wontfix

Comments

@NOhs
Copy link
Collaborator

NOhs commented May 2, 2018

There is really no reason to have a copy of the Eigen repository in this repo just to use it in a MWE. We should replace it by a dummy library. That should be enough for the unit tests.
@NOhs NOhs added the discussion Something that might end up being labled enhancement or wontfix label May 2, 2018
@NOhs NOhs self-assigned this May 5, 2018
@NOhs
Copy link
Collaborator Author

NOhs commented May 10, 2018

Closed by #45

@NOhs NOhs closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NOhs NOhs

Labels
discussion Something that might end up being labled enhancement or wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NOhs