Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External keyword might be unnecessary #42

Closed
NOhs opened this issue May 6, 2018 · 2 comments
Closed

External keyword might be unnecessary #42

NOhs opened this issue May 6, 2018 · 2 comments
Labels
discussion Something that might end up being labled enhancement or wontfix

Comments

@NOhs
Copy link
Collaborator

NOhs commented May 6, 2018

It seems to me that we can infer from the input in the toml if the target is external or not. So maybe it is not needed. This would simplify the toml script and be in line with the idea to make everything as simple/smart as possible.
@NOhs NOhs added the discussion Something that might end up being labled enhancement or wontfix label May 6, 2018
@GPMueller
Copy link
Contributor

Agreed. If a url is specified, the target is automatically external and if it comes from a directory, there is no need to copy the sources into the build directory.

@GPMueller
Copy link
Contributor

Implemented on PR #44, which was merged with d0a3090.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Something that might end up being labled enhancement or wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GPMueller @NOhs