Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging setup mixed into main function #60

Closed
NOhs opened this issue Aug 28, 2018 · 3 comments
Closed

Logging setup mixed into main function #60

NOhs opened this issue Aug 28, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@NOhs
Copy link
Collaborator

NOhs commented Aug 28, 2018

Logging setup is part of the Environment constructor. Logging formatting setup, however, should not be part of the clang build main function. Changing this will fix the tests logging everything multiple times.
@NOhs NOhs added the bug Something isn't working label Aug 28, 2018
@GPMueller
Copy link
Contributor

At which point should the logger be setup instead?
Also, the now unneeded '-p' flags can be removed from the test.py to clean up the output.

@GPMueller
Copy link
Contributor

Fixed with 8a9f8c2 on feature-sources-patterns (PR #63).

@GPMueller GPMueller mentioned this issue Sep 23, 2018
Merged
2 tasks
@GPMueller
Copy link
Contributor

Merged with 013871d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GPMueller @NOhs