Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove Functionality #2

Merged
merged 8 commits into from Apr 28, 2022
Merged

Add/Remove Functionality #2

merged 8 commits into from Apr 28, 2022

Conversation

Trictonicmp
Copy link
Owner

Add/Remove

in this PR I:

  • Added CSS variables to be able to make a dark-mode in a future PR
  • Added a Favicon icon
  • Added a function to be able to select list items
  • Added a function to edit the list item
  • Added a function to add a new list item
  • Added a function to remove a list item
  • Added a function to update each list item index
  • Added a function to save the local storage data as the user makes changes on a list item
  • Changed the structure of the HTML list items

Copy link

@keroloussamy keroloussamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Trictonicmp,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To highlight 🎯

  • No linter errors.✔️
  • Good code design and implementation. ✔️
  • Add all the requirements. ✔️

clap

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Trictonicmp Trictonicmp merged commit c006db4 into master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants