#492 runnable_in_console option #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkdrns4747
added
the
category:feature-request
This PR #493 may also have some effects from the |
wysohn
requested changes
Sep 18, 2022
| public abstract Object createEmptyPlayerEvent(ICommandSender sender); | ||
|
|
||
| public abstract Object createPlayerCommandEvent(ICommandSender sender, String label, String[] args); | ||
| public abstract Object createCommandEvent(ICommandSender sender, String label, String[] args); |
There was a problem hiding this comment.
I would suggest creating a separate method and leave the previous method for now. Maybe also mark as deprecated if it will be removed.
You may rename it in the next version
| @@ -592,6 +591,19 @@ public void onSave(String script) { | |||
| trigger.getInfo().setSync(!trigger.getInfo().isSync()); | |||
|
|
|||
| sender.sendMessage("&7Sync mode: " + (trigger.getInfo().isSync() ? "&a" : "&c") + trigger.getInfo().isSync()); | |||
| saveAsynchronously(getCmdManager()); | |||
| } else if (args.length == 3 && getCmdManager().has(args[1]) && args[2].equalsIgnoreCase("console")) { | |||
There was a problem hiding this comment.
Maybe getCmdManager().has(args[1]) can be checked inside the block and give the feedback as necessary?
| @@ -28,6 +26,8 @@ public IEntity wrap(Entity entity) { | |||
|
|
|||
| public abstract IPlayer wrap(Player player); | |||
|
|
|||
| public abstract IConsoleCommandSender wrap(ConsoleCommandSender sender); | |||
There was a problem hiding this comment.
Is implementation for BukkitConsoleCommandSender differ between latest and legacy versions? Or we could just make it a concrete method
| @@ -455,8 +458,9 @@ public IPlayer getPlayer(String string) { | |||
| return null; | |||
| } | |||
|
|
|||
| public ICommandSender getConsoleSender() { | |||
There was a problem hiding this comment.
Same: leave it and change in next version
| @@ -476,7 +480,7 @@ public HandlerList getHandlers() { | |||
| } | |||
| } | |||
|
|
|||
| public Object createPlayerCommandEvent(ICommandSender sender, String label, String[] args) { | |||
There was a problem hiding this comment.
Same: leave it and change in next version
| @Override | ||
| public Object createEmptyPlayerEvent(ICommandSender sender) { | ||
| return bukkit.createEmptyPlayerEvent(sender); | ||
| } | ||
|
|
||
| @Override | ||
| public Object createPlayerCommandEvent(ICommandSender sender, String label, String[] args) { |
There was a problem hiding this comment.
Same: leave it and change in next version
nicosammito
reviewed
Oct 29, 2022
| @@ -11,4 +13,7 @@ public IPlayer wrap(Player player) { | |||
| return new BukkitPlayer(player); | |||
| } | |||
|
|
|||
| @Override | |||
| public IConsoleCommandSender wrap(ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} | |||
There was a problem hiding this comment.
Suggested change
| public IConsoleCommandSender wrap(ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} | |
| public IConsoleCommandSender wrap(final ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} |
| @@ -11,4 +13,6 @@ public IPlayer wrap(Player player) { | |||
| return new BukkitPlayer(player); | |||
| } | |||
|
|
|||
| @Override | |||
| public IConsoleCommandSender wrap(ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} | |||
There was a problem hiding this comment.
Suggested change
| public IConsoleCommandSender wrap(ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} | |
| public IConsoleCommandSender wrap(final ConsoleCommandSender sender) {return new BukkitConsoleCommandSender(sender);} |
|
|
||
| public class BukkitConsoleCommandSender implements IConsoleCommandSender { | ||
| private final ConsoleCommandSender sender; | ||
| public BukkitConsoleCommandSender(ConsoleCommandSender sender){ |
There was a problem hiding this comment.
Suggested change
| public BukkitConsoleCommandSender(ConsoleCommandSender sender){ | |
| public BukkitConsoleCommandSender(final ConsoleCommandSender sender){ |
| this.sender = sender; | ||
| } | ||
| @Override | ||
| public void sendMessage(String message) { |
There was a problem hiding this comment.
Suggested change
| public void sendMessage(String message) { | |
| public void sendMessage(final String message) { |
| } | ||
|
|
||
| @Override | ||
| public boolean hasPermission(String permission) { |
There was a problem hiding this comment.
Suggested change
| public boolean hasPermission(String permission) { | |
| public boolean hasPermission(final String permission) { |
| @@ -476,7 +480,7 @@ public HandlerList getHandlers() { | |||
| } | |||
| } | |||
|
|
|||
| public Object createPlayerCommandEvent(ICommandSender sender, String label, String[] args) { | |||
| public Object createCommandEvent(ICommandSender sender, String label, String[] args) { | |||
There was a problem hiding this comment.
Suggested change
| public Object createCommandEvent(ICommandSender sender, String label, String[] args) { | |
| public Object createCommandEvent(final ICommandSender sender, final String label, final String[] args) { |
| public IConsoleCommandSender getConsoleCommandSender() { | ||
| return bukkit.getConsoleSender(); | ||
| } | ||
|
|
||
| @Override | ||
| public Object createEmptyPlayerEvent(ICommandSender sender) { |
There was a problem hiding this comment.
Suggested change
| public Object createEmptyPlayerEvent(ICommandSender sender) { | |
| public Object createEmptyPlayerEvent(final ICommandSender sender) { |
| @Override | ||
| public Object createEmptyPlayerEvent(ICommandSender sender) { | ||
| return bukkit.createEmptyPlayerEvent(sender); | ||
| } | ||
|
|
||
| @Override | ||
| public Object createPlayerCommandEvent(ICommandSender sender, String label, String[] args) { | ||
| return bukkit.createPlayerCommandEvent(sender, label, args); | ||
| public Object createCommandEvent(ICommandSender sender, String label, String[] args) { |
There was a problem hiding this comment.
Suggested change
| public Object createCommandEvent(ICommandSender sender, String label, String[] args) { | |
| public Object createCommandEvent(final ICommandSender sender, final String label, final String[] args) { |
Comment on lines
+184
to
+189
| Map<String, Object> varMap = new HashMap<>(); | ||
| varMap.put("isByPlayer", false); | ||
| varMap.put("sender", sender); | ||
| varMap.put("command", cmd); | ||
| varMap.put("args", args); | ||
| varMap.put("argslength", args.length); |
There was a problem hiding this comment.
Suggested change
| Map<String, Object> varMap = new HashMap<>(); | |
| varMap.put("isByPlayer", false); | |
| varMap.put("sender", sender); | |
| varMap.put("command", cmd); | |
| varMap.put("args", args); | |
| varMap.put("argslength", args.length); | |
| Map<String, Object> varMap = Map.of("isByPlayer", true, "sender", sender, "command", cmd, "args", args, "argslength", args.length); |
| return console_available; | ||
| } | ||
|
|
||
| public void setConsoleAvailable(boolean bool){ |
There was a problem hiding this comment.
Suggested change
| public void setConsoleAvailable(boolean bool){ | |
| public void setConsoleAvailable(final boolean bool){ |
|
this branch is stale for long time and is unlikely cleanly merged Suggested to create a new branch and replicate the changes there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Check This Comment