Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #39
In this pr:
webview context menu support three main (basic) features:
And I did try to use Obsidian default context menu api, I found it is diffcult to handle the context menu life cycle because when we click on the iframe in the webview, obsidian didn't react to it.
And there are still some features / command to be added into the context menu.
is used for detect url like :
https://github.com/Trikzon/obsidian-web-browser/compare/main...Quorafind:obsidian-web-browser:feature/webview-context-menu?expand=1#diff-62273fc3fd92e90a0259fd41071a9a4114ec24773a46aff160f748c2376128faR209