Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome 5 webpack bundle size on latest release #126

Closed
LH221 opened this issue Apr 17, 2019 · 2 comments
Closed

Font Awesome 5 webpack bundle size on latest release #126

LH221 opened this issue Apr 17, 2019 · 2 comments

Comments

@LH221
Copy link

LH221 commented Apr 17, 2019

By default the main chunk size for production is:

main.js 1.12 MiB 0 [emitted] [big] main

This seemes to be caused by using the require function to import the icons:

library.add(
require('@fortawesome/free-solid-svg-icons').faEnvelope,
...
)

still imports the entirety of @fortawesome/free-solid-svg-icons in the chunk it seems.

Just changing the code to the following (as documented by vue-fontawesome) results in a dramatic reduction:

import { faEnvelope, faHeart, faGraduationCap, faHome, faInfo, faList, faSpinner } from '@fortawesome/free-solid-svg-icons'
import { faFontAwesome, faMicrosoft, faVuejs } from '@fortawesome/free-brands-svg-icons'
library.add(faEnvelope, faHeart, faGraduationCap, faHome, faInfo, faList, faSpinner, faFontAwesome, faMicrosoft, faVuejs)

main.js 81.5 KiB 0 [emitted] main

@MarkPieszak
Copy link
Member

MarkPieszak commented Apr 19, 2019

Fantastic find I should of fixed this LONG ago :)

Thanks for pointing it out!!

Pushing up an update with this to the repo & Nuget.

@MarkPieszak
Copy link
Member

Published on Nuget as 1.0.9 now - thanks again! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants