Notes on Upgrading to Angular 8

[chriszrc]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Everything works with Angular 7, but if you upgrade your cli and then upgrade the angular universal app:

npm install -g @angular/cli@next
ng update @angular/cli @angular/core codelyzer --next

A couple of problems appear:

1. Angular complains about the lazy loading of modules unless you change the "compilerOptions"->"module":"esNext" in the tsconfig.app.json file
2. If you try the SSR build, you get the error already reported here - Module not found: Error: Can't resolve 'string-replace-loader' in... nestjs/ng-universal#64
3. The SSR build fails, because the ng-universal/webpack-config.factory.js has this section:

test: /\module.ts$/,
                        loader: 'string-replace-loader',
                        options: {
                            search: '../server/main',
                            replace: '../dist/server/main',
                            flags: 'g'
                        }

and apparently in the latest version of string-replace-loader, including any flags in the options turns on regex, and because the periods are in there unescaped, it totally messes the replacement-

Expected behavior

Should work with Angular 8 :)

Minimal reproduction of the problem with instructions

See above

What is the motivation / use case for changing the behavior?

Getting ready for Angular 8!

Environment

Nest version: 6.0.1

 
For Tooling issues:
- Node version: 10.15.3  
- Platform:  Mac

Others:

[kamilmysliwiec]

Thanks for sharing your experiences. Once Angular 8 is officially published, I'll update an example.

[michaeljota]

@kamilmysliwiec Now that Angular 8 was officially released, can we expect this to work? Looking forward to it. Thanks!

[marcellkiss]

I just started a new project with the latest ng cli (v8), would be happy to use universal-nest

[marcellkiss]

*despite the warnings, v1.1.1 seems to work fine with angular 8.x

[kamilmysliwiec]

Repo updated :)