Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add kwargs types for Client.add_torrent #108

Merged
merged 17 commits into from
Sep 24, 2021

Conversation

trim21
Copy link
Owner

@trim21 trim21 commented Sep 23, 2021

    def add_torrent(
        self,
        torrent: Union[BinaryIO, str, bytes],
        timeout: _Timeout = None,
        *,
        download_dir: str = None,
        files_unwanted: List[int] = None,
        files_wanted: List[int] = None,
        paused: bool = None,
        peer_limit: int = None,
        priority_high: List[int] = None,
        priority_low: List[int] = None,
        priority_normal: List[int] = None,
        cookies: str = None,
        bandwidthPriority: int = None,
    ) -> Torrent:

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #108 (aa0cc19) into master (ea56a10) will decrease coverage by 0.43%.
The diff coverage is 91.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   71.44%   71.00%   -0.44%     
==========================================
  Files          13       13              
  Lines        1180     1228      +48     
==========================================
+ Hits          843      872      +29     
- Misses        337      356      +19     
Flag Coverage Δ
pypy3 71.00% <91.83%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
transmission_rpc/constants.py 95.00% <ø> (ø)
transmission_rpc/utils.py 65.76% <79.48%> (-16.43%) ⬇️
tests/test_client.py 97.38% <100.00%> (+0.30%) ⬆️
transmission_rpc/client.py 64.05% <100.00%> (+0.36%) ⬆️
transmission_rpc/error.py 88.23% <100.00%> (+13.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea56a10...aa0cc19. Read the comment docs.

@trim21 trim21 merged commit e5c762d into master Sep 24, 2021
@trim21 trim21 deleted the refactor/rpc-version-check branch September 24, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant