Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client)!: add_torrent support pathlib.Path #112

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

trim21
Copy link
Owner

@trim21 trim21 commented Sep 29, 2021

BREAKING CHANGE:

  • Client().add_torrent: base64 encoded str as torrent is ambiguous and deprecated, will be removed in v4

@trim21 trim21 changed the title feat(client): add_torrent support pathlib.Path feat(client)!: add_torrent support pathlib.Path Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #112 (c3c58e3) into master (641cabb) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head c3c58e3 differs from pull request most recent head 63e5092. Consider uploading reports for the commit 63e5092 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   73.50%   73.66%   +0.16%     
==========================================
  Files          14       14              
  Lines        1287     1295       +8     
==========================================
+ Hits          946      954       +8     
  Misses        341      341              
Flag Coverage Δ
3.6 73.46% <100.00%> (+0.16%) ⬆️
3.7 73.46% <100.00%> (+0.16%) ⬆️
3.8 73.64% <100.00%> (+0.16%) ⬆️
3.9 73.64% <100.00%> (+0.16%) ⬆️
pypy3 73.46% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
transmission_rpc/client.py 64.05% <ø> (ø)
tests/test_client.py 97.46% <100.00%> (+0.06%) ⬆️
transmission_rpc/utils.py 66.95% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641cabb...63e5092. Read the comment docs.

BREAKING CHANGE:
`add_torrent`: base64 encoded str as torrent is deprecated, and will be removed in v4
@trim21 trim21 changed the title feat(client)!: add_torrent support pathlib.Path feat(client)!: add_torrent support pathlib.Path Sep 29, 2021
@trim21 trim21 merged commit 53e9edd into master Sep 29, 2021
@trim21 trim21 deleted the add-pathlib-torrent branch September 29, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant