Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client)!: deprecating relative Path as remote path #113

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

trim21
Copy link
Owner

@trim21 trim21 commented Sep 29, 2021

BREAKING CHANGE:

  • Client: use relative pathlib.Path as remote path for .move_torrent_data(), .locate_torrent_data(), .rename_torrent_path() and .free_space() is deprecated.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #113 (07cf8aa) into master (c828c40) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   73.66%   73.98%   +0.31%     
==========================================
  Files          14       14              
  Lines        1295     1307      +12     
==========================================
+ Hits          954      967      +13     
+ Misses        341      340       -1     
Flag Coverage Δ
3.6 73.78% <100.00%> (+0.32%) ⬆️
3.7 73.78% <100.00%> (+0.32%) ⬆️
3.8 73.96% <100.00%> (+0.31%) ⬆️
3.9 73.96% <100.00%> (+0.31%) ⬆️
pypy3 73.78% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_client.py 97.60% <100.00%> (+0.13%) ⬆️
transmission_rpc/client.py 64.57% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c828c40...07cf8aa. Read the comment docs.

@trim21 trim21 merged commit 8dd089f into master Sep 29, 2021
@trim21 trim21 deleted the deprecate-rel-pathlib-path branch September 29, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant