Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download_dir property #62

Merged
merged 5 commits into from Mar 16, 2021
Merged

add download_dir property #62

merged 5 commits into from Mar 16, 2021

Conversation

Tathar
Copy link
Contributor

@Tathar Tathar commented Mar 15, 2021

close #

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #62 (dfc3e10) into master (3052051) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   70.73%   70.72%   -0.02%     
==========================================
  Files          12       12              
  Lines        1155     1158       +3     
==========================================
+ Hits          817      819       +2     
- Misses        338      339       +1     
Flag Coverage Δ
py_36 ?
py_37 ?
py_38 ?
py_39 70.70% <66.66%> (-0.02%) ⬇️
py_pypy3 70.47% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
transmission_rpc/torrent.py 57.28% <66.66%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3052051...dfc3e10. Read the comment docs.

@trim21
Copy link
Owner

trim21 commented Mar 15, 2021

please document which transmission and RPC version this property is available in source code comments.

Copy link
Owner

@trim21 trim21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@trim21 trim21 merged commit 099a590 into trim21:master Mar 16, 2021
@Tathar Tathar deleted the patch-1 branch March 25, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants