Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Core/Misc: Remove the use of logging system from WPFatal (Fixes tools…
… compile) Closes #9501
- Loading branch information
Showing
3 changed files
with
43 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WPAssert wasn't using logging system
WPError and WPWarnings are unused
WPFatal was only used when connecting to DB
So makes sense to me to remove Logging system from this file... also probably now makes sense to move function back to .h to remove the need to link shared to collision
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, and +1 on adding the licenses and copyright holders.
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why mangos copyright? :)
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple TrinityCore is derived from Massive Network Game Object Server
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... You don't say? That doesn't mean files created newly solely for and by TrinityCore need copyright to mangos. >_>
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but is derived from MaNGOS, he have his credits you have tyu understand it, and althought have a base of MaNGOS, for this reason put the copyright of MaNGOS you understand this?
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsa @boxa @mns have contributed alot in this time to TrinityCore
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only add Mangos credits on files that comes from Mangos, on own Trinitycore files or full rewriten files there is no need of add Mangos (C) or can be removed.
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dokman please...
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahaha nice catch @Discover! I bet there are bunch of files in tc with wrong copyrights...
3c6c8c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a copy and paste :) in fact no need to be there.