Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] New orgrimmar spawns + Brawl'gar arena #14638

Closed
ElleEntertainment opened this issue May 2, 2015 · 17 comments
Closed

[6.x] New orgrimmar spawns + Brawl'gar arena #14638

ElleEntertainment opened this issue May 2, 2015 · 17 comments

Comments

@ElleEntertainment
Copy link

Deleted all orgrimmar spawns with new (sniffs from 6.1.2 retail)
Added spawns + areatrigger of brawl'gar arena
http://pastebin.com/TunVtbpp

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Kinzcool
Copy link
Contributor

Kinzcool commented May 2, 2015

Don't delete all the old ones as they are correct. Just look through your data, and try to filter the IDs higher than cata for both, gameobjects and creatures. Exception cases of moved NPCs or GOs can be looked after later if you don't know them.

@gegge
Copy link
Contributor

gegge commented May 2, 2015

Ok so for example 4000 is the highest id for cataclism, i should only insert ids > than 4000, is it right?

@Killyana
Copy link
Member

Killyana commented May 2, 2015

The highest id is 58864 for cataclysm.

@ElleEntertainment
Copy link
Author

and for gameobject?

@Kinzcool
Copy link
Contributor

Kinzcool commented May 2, 2015

For gameobjects, MoP IDs start at 209k. As of creatures, 58864 is indeed the highest ID, but be sure to watch out for MoP creatures that would have been created prior to cata's IDs; their IDs start at ~52k.

@Killyana
Copy link
Member

Killyana commented May 2, 2015

We have object ids until 211084 on 4.x DB

@ElleEntertainment
Copy link
Author

http://pastebin.com/6QbQeF8R

now it should be correct ;)

@Aokromes
Copy link
Member

Aokromes commented May 3, 2015

ugly like hell sql.

@ElleEntertainment
Copy link
Author

it is gives no error btw..

@Kinzcool
Copy link
Contributor

Kinzcool commented May 3, 2015

Codesyle does matter, and also please use gist instead of pastebin for fixes.

@ElleEntertainment
Copy link
Author

oook

@ghost
Copy link

ghost commented May 3, 2015

@ElleEntertainment : in case you haven't had time to clean up that pastebin SQL, I have created a gist version for you with the top section cleaned up: https://gist.github.com/tkrokli/ec5042be578c3a272fdc

Notice also that I have added a couple of questions and suggestions towards the end of that page.

@Aokromes
Copy link
Member

This can be merged?

@ghost
Copy link

ghost commented Mar 26, 2017

SET @CGUID := 370837; needs to be checked first to see if that GUID is free.
Otherwise, you know just as much as me about checking if it works as intended.

@Aokromes
Copy link
Member

Aokromes commented Mar 26, 2017

It needs to be 450 000+ because it's mop+ spawns

@ghost
Copy link

ghost commented Mar 26, 2017

Replaced the GUID value with XXXXXX and added a comment. Also removed the incorrect column names for the areatrigger_teleport query, which seems less than complete (maybe it should have been replaced with an UPDATE query instead? (Don't have the master DBs rebuilt on my computer at the moment, feel free to check the areatrigger_teleport part vs master branch.)

@Aokromes
Copy link
Member

Aokromes commented Jan 6, 2018

4810e02

@Aokromes Aokromes closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants