[3.3.5][Core/SmartAI] No Bag Space

[ghost]

Hello. Trying to learn more about SmartAI.
Noticed an issue with some parts of cast spell / summon object.

Cast Spell: Working fine when you want the creature to cast a spell (buff) on any nearby player.
Once you want the creature to cast a spell (buff) on a specific player (pvp example: - a player dies, the one who won the fight, gets a buff) this aint working at all. In fact, the creature tries to add the buff to my bags. resulting in a message saying " You don't have any space in your bags ". I've tried to solve this by using creature and objects. doesn't help.

Summon Object: Since the cast spell didn't work, i figured, i'd want the creature to spawn an object (chest) so that the player who opens this chest, gets his reward. Somehow, this aint working aswell. The creature (once again) thinks, it needs to add the object to my bags. resulting in the same message as previously " You don't have any space in your bags "

With this in mind, the creature does, recognize the player who slain the other. It just doesn't seem like the creature gets to cast / spawn what its been told to.

SQL example on spawning object:

-- PVP Watcher SAI
SET @ENTRY := 50013;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,74,0,100,0,0,0,1,1,50,153464,120,0,0,0,0,1,0,0,0,0,0,0,0,"On Player Death, spawn object");

SQL example on adding spell (buff) to player who won the fight:

-- PVP Watcher SAI
SET @ENTRY := 50013;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,74,0,100,0,0,0,1,1,11,29519,34,0,0,0,0,7,0,0,0,0,0,0,0,"On Player Death, add buff");

Core Info:
Trinitycore 3.3.5
Lastest Commit: b630829
Just updated the core, about 10mins ago
Windows 7 64bit
No modifications has been done to the DB

[ghost]

Just a helpful tip to make your SQL examples easier to read :
Add ```sql on a single blank line before each example to make them highlighted as SQL code.

Then add ``` (3 back ticks) on a blank line after each of the examples.

[ghost]

Thanks.
Updated.

[MrSmite]

Isn't the spell you're casting trying to create an item though? Maybe your bags are actually full?

29519 - Silithyst

Silithyst dust surrounds and burdens you. You cannot carry it on your mount, and it impedes the use of any speed enhancements.

Comments
If this is your first time finding Silithyst and you are here wondering about what it is, here is a little bit of information you may find useful.

It can be collected from any Silithyst Geyser that are located around Silithus,

The Silithyst itself will slow the holder down, preventing any speed increased effects from working (including ghost wolf etc) and will be dropped if the player mounts. If dropped by a player it can by [sic] picked up again by right clicking the dropped Silithyst Mound, this gives the Silithyst buff (and the red aura) back to the player, showing that the player is carrying it.

[ghost]

Lemme stop you right there MrSmite.
Silithyst is both.
you quote: It can be collected from any Silithyst Geyser that are located around Silithus.
once its picked up, it cast a spell/buff on you.
the only way it'll create and object is when you mount up or left-click the spell/buff.
I modified the spell so that it wont create an object if its removed also so that when you mount up, you don't lose it.

I did attempt with other buffs such as a simple Stamina buff.
It wont work, nomatter how i try.

[ghost]

I was going to comment on this about 8 hours ago, but I was too tired to look up the right facts.

http://www.wowhead.com/spell=29519/silithyst
http://wotlk.openwow.com/spell=29519

• Spell 29519 has 3 effects, all of them only applying auras, not creating any objects.
• Spell 29519 is placed in the action_param1 column.

I don't really see any issue with that part, though I don't know enough about what action_param 1 - 6 does. I tried looking it up, but the TC wiki description of action_param is missing or remvoved.

What I do question instead, is the behaviour of the spell aura when you mount up. As far as I can remember from 2007-2010, you are supposed to lose the buff / aura when you mount up, because you are supposed to walk (run slow) to the faction camp while carrying the "flag" with you. The PvP activity in Silithus is after all a Capture The Flag game. (This is at least the Blizzlike behaviour.)

I remember @Killyana worked on fixing the interaction between the silithyst game object and receiving the buff some weeks ago, but I have not taken the time to test it later. I hope someone who has tested it can comment on this issue, so we can have some relevant feedback on this.

[MrSmite]

Hmm, well perhaps the problem is an NPC trying to cast it? The spell works if you cast it on yourself (GM command) but it requires that you be in Silithus or it errors with "You are in the wrong zone".

Also, lookup item Silithus does result in 23567 [PH] Silithus PvP Dust [DEP] which you can create using additem so I wonder if it is trying to create that item?

Side Note: The debuff doesn't appear to slow my test Hunter, with or without Aspect of the Cheetah

I remember @Killyana worked on fixing the interaction between the silithyst game object and receiving the buff some weeks ago, but I have not taken the time to test it later. I hope someone who has tested it can comment on this issue, so we can have some relevant feedback on this.

Clicking on the geyser just makes it disappear without giving the debuff. Searching the repo shows
one PR that was randomly closed without being updated and merged.

[Killyana]

To be honest SAI is not adapted to script such things, it must be done by cpp, also some spells like http://www.wowhead.com/spell=29519/silithyste have an area conditions and cannot be used every where, and the event SMART_EVENT_FRIENDLY_HEALTH_PCT cannot be used like this, also you cannot cast spells in death players (only some specific spells)

[ghost]

@MrSmite : OK, thanks for the feedback. I was actually thinking about #14637 and 3720be3 , I didn't notice the commit 8f3a9b7 before. I guess those commits didn't solve the issue of picking up the items, if neither of you can pick it up. I will have to test this by going there with a DK or some other OP character and see if I can reproduce the issue.

[Rushor]

well then, just fix this with a propper c++ script, because we don't need such a fix for SAI, because it will only be needed in very few cases. SAI was implemented to script general behaviour for creature-player interaction, like killxana said.