[3.3.5][6.x][Core/Spell] Venomhide Poison - Enchant with wrong duration

[Rushor]

rev: c6c3e72

Facts:
http://www.wowhead.com/spell=14792/venomhide-poison
You get this echantspell if you fight against http://www.wowhead.com/npc=6508/venomhide-ravasaur

Problem:
The duration of the enchant:
Enchant Held Item (OBSOLETE): Venomhide Poison (1003)
holds 9 HOURS

How it should be:
Enchant Held Item (OBSOLETE): Venomhide Poison (1003)
The duration should be 5 MINUTES.
The procchance and the procflags are all correct. it's only an issue with the duration of the enchant

Source:
Venomhide Poison is a temporary weapon enchantment that lasts for 5 minutes.
http://wowwiki.wikia.com/wiki/Venomhide_Poison

What i tried to fix the issue:
https://github.com/TrinityCore/TrinityCore/blob/6.x/src/server/game/Spells/SpellEffects.cpp#L2692
I added the spellinfo:

else if (m_spellInfo->Id == 14792)
        duration = 300;                                     // 5 mins

but this didn't changed anything. so i'm pretty lost here :D

sideproblem: many people abuse this enchant to deal further damage in raids

[digz6666]

Confirmed, it's on top damage of skill for paladin's in raid.

[Rushor]

you can reduce the damage if you disable the sp scailing in spell_bonus_data
(that's a quick solution, but all we actually need is a fix for the duration)

[Shauren]

The effect is EnchantHeldItem, not EnchantItemTemporary

[Rushor]

then it's even more strange:
https://github.com/TrinityCore/TrinityCore/blob/6.x/src/server/game/Spells/SpellEffects.cpp#L4117
ID - 14792
Duration: ID (9) 30000, 0, 30000

[Shauren]

Actually, its not. see here:
https://github.com/TrinityCore/TrinityCore/blob/6.x/src/server/game/Spells/SpellEffects.cpp#L4135
30s * 1000 -> 8 hours and 20 minutes (ingame 9 hours until it falls below 8 hours)
Yes, this is a bug.

[Rushor]

there are only 3 spells which use this effect
ID - 53160 Dancing Rune Weapon Visual
ID - 19108 MHTest02
and the already known spell

would it be save to change the multiplier to 10 since 53160 has a unlimited duration and 19108 does not have a duration at all?

[Shauren]

why any multiplier? spell in this issue clearly has a custom duration (5 minutes)

[Rushor]

the duration is only 30 seconds (duration of the debuff) but it must be 5 minutes for the enchant, so * 10 is needed :/
where do you see the 5 minutes duration in 14792?

[Shauren]

I do not. But duration of the debuff is not related in anyway to duration of the enchantment - just hardcode if (m_spellInfo->Id == 14792) duration=5 * MINUTES * IN_MILLISECONDS;

[Rushor]

o7 kay

[Rushor]

c04c409 thanks for all the help