[3.3.5] DB/Creature: Prince Valanar walking on ground level (Death's Breach)

[ghost]

TrinityCore rev. c606ac5 2016-01-20 01:38:30 +0100 (3.3.5 branch) (Win64, Release),
TDB 335.60 + all updates up to and including 2016_01_20_01_world.sql

This is a continuation of issue #1674, Prince Valanar has still got the same issue of walking on ground level when he should be walking on top of the podium. This is the phase where you have accepted the quest "The Will of the Lich King" (http://www.wowhead.com/quest=12714/the-will-of-the-lich-king) from Highlord Darion Mograine and go to Prince Valanar down on Death's Breach to deliver it to Prince Valanar, then picking up the quest "The Crypt of Remembrance" (http://www.wowhead.com/quest=12715/the-crypt-of-remembrance).

In-game screenshot:

No game addons, straight TC 3.3.5 source with no extra code added (core rev. hash also in the image).

[Takenbacon]

Do you have vmaps extracted and enabled?

[ghost]

Oh yes, they certainly are. DBC, maps, Vmaps and Mmaps are extracted from the same game client as the one I use to play the game. I extract new DBC/maps files at least once each month. I always enable Mmaps because I know how weird NPCs behave when Mmaps are disabled. Vmaps are always enabled in my worldserver.conf file by default (TrinityCore default). I never change that Vmaps part.

[Kittnz]

I'v seen this aswell, from what i understand is the gob is spawned after the npc and thats why the npc is inside it

[Aokromes]

Strange, i am sure this was fixed long, long time ago.

[ghost]

It might have worked before, but there are still things like this happening other places in the source too. Example: Item "Instant Statue Pedestal" not working #10599

I also thought about including the Lich King having the same issue for the quest "The Scarlet Apocalypse" like it was before in the issue [NPC] Prince Valanar and Lich King are underground #5636 , but I am uncertain if they are separate issues or not (see issue #5636 for more details).

---

Edit: Another example of wrong "cosmetic" behaviour by NPCs in the same area: NPC Death Knight Initiate DB entry 28406 / guid 129547, the only one of them (which I have noticed) that is mounted on a (Riding) Skeletal Gryphon, drops from the sky down to ground level each time I move into the area "Death's Breach". Even if I just leave the plateau and come back, it repeats the "falling from the sky" behaviour. I know that this particular case belongs in a different issue. I just wanted to mention it as an example of more things to fix in that area.

[LordUsagi]

I think in the case of 129547 he should probably have a flying flag, if he is spawned up in the air.

[ghost]

@LordUsagi : Good idea, although I don't have the sniff values available for guid 129547 to check if it should be flying. Currently, its InhabitType = 3 (Ground + Water) (https://trinitycore.atlassian.net/wiki/display/tc/creature_template#creature_template-InhabitType), although I am confused about the meaning of this NPC being mounted as well as having the same gossip as the other Death Knight Initiates who are available for the quest "Death's Challenge": Are you challenging me, $g brother:sister;?.

---

Edit: this NPC guid 129547: MovementType= 1 (Random movement inside the spawndist radius)

SELECT * FROM `creature` WHERE `id`= 28406 AND `guid`= 129547;

  guid      id     map  zoneId  areaId  spawnMask  phaseMask  modelid  equipment_id  position_x  position_y  position_z  orientation  spawntimesecs  spawndist  currentwaypoint  curhealth  curmana  MovementType  npcflag  unit_flags  dynamicflags  VerifiedBuild
------  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ---------------
129547   28406     609       0       0          1          1    25412             1     2354.22    -5684.23     179.688       6.2246            360          5                0       2614     2117             1        0           0             0              0

[ghost]

@tkrokli I believe on retail they fly down, dismount and become targets players can duel.

[ghost]

OK, then that guid needs some scripting, although I am uncertain how that works when the only difference is the GUID and not the creature_template.entry 28406 (which includes all the others).

[ghost]

The mount should be done in creature_addon and the SAI would need to be done with the guid, though I do not know if that overrides the entry SAI.

[ghost]

https://trinitycore.atlassian.net/wiki/display/tc/smart_scripts#smart_scripts-entryorguid
Yes, I see now that it should be possible to write a SAI for a specific GUID, although I don't know if we have got sniffs for the movement of guid = 129547. Maybe we have, maybe you can get it if we don't.
I must admit that I have never noticed that this specific NPC flew before landing and then dismounted. It would be cool if you could confirm that this is what happens to that NPC in that phase of this area. :)

---

Edit: I tried to search a 36 MB V3_3_5_12213 sniff for that specific NPC in that position, but I found it too difficult to single out one or just a few exact GUIDs of the 4900+ hits for NPC entry 28406 in that file. The main trouble is that Blizzard used/uses dynamic GUIDs so they don't match the TC GUIDs.

[LordUsagi]

We should probably open a second issue, we're breaking away from the main point.

[ghost]

True. I will start moving my info to a new issue as soon as I have completely rewritten my latest PR.

[ghost]

@kizarr : that "fix" is hacky and unacceptable, TC will not set quests to autocomplete when the quests are functional as they are. Your DELETE FROM queries are wrong too, use BETWEEN @GUID AND @GUID+xx. Also, spawning of more creatures can only be accepted if it is based on sniffs. And this is just from superficial browsing through that SQL, without looking closer at the details.

[ghost]

If you get rid of the 'quest autocomplete' parts, maybe then we can talk about which parts can be looked at closer to see if there is anything useful in there. I don't know how soon I will have time to check out the spawning, but maybe I will test just the NPC spawn part to see if it contains anything useful or valid.

[ghost]

Huh? What on earth has http://www.wowhead.com/npc=4727/elder-thunder-lizard got to do with this?

[lyn1337]

hæ?
@tkrokli maybe it does fix the issue. ;) ;)

[ghost]

Lol, are we reading the same thing? from Kizarr's pastebin link http://pastebin.com/v1ReguQ9

INSERT INTO `creature` (`guid`, `id`, `map`, `spawnMask`, `phaseMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `DeathState`, `MovementType`) VALUES
(28907,4727,1,1,1,0,0,-1724.81,2862.98,78.5843,3.12499,300,5,0,1536,0,0,1),
(28907,4727,1,1,1,0,0,-1724.81,2862.98,78.5843,3.12499,300,5,0,1536,0,0,1),

id in creature table = entry in creature_template :

SELECT * FROM `creature` WHERE `id` = 4727;

(result: 40 creatures with the same entry)

SELECT * FROM `creature_template` WHERE `entry` = 4727;

 entry  difficulty_entry_1  difficulty_entry_2  difficulty_entry_3  KillCredit1  KillCredit2  modelid1  modelid2  modelid3  modelid4  name                  subname  IconName  gossip_menu_id  minlevel  maxlevel     exp  faction  npcflag  speed_walk  speed_run   scale    rank  dmgschool  BaseAttackTime  RangeAttackTime  BaseVariance  RangeVariance  unit_class  unit_flags  unit_flags2  dynamicflags  family  trainer_type  trainer_spell  trainer_class  trainer_race    type  type_flags  lootid  pickpocketloot  skinloot  resistance1  resistance2  resistance3  resistance4  resistance5  resistance6  spell1  spell2  spell3  spell4  spell5  spell6  spell7  spell8  PetSpellDataId  VehicleId  mingold  maxgold  AIName  MovementType  InhabitType  HoverHeight  HealthModifier  ManaModifier  ArmorModifier  DamageModifier  ExperienceModifier  RacialLeader  movementId  RegenHealth  mechanic_immune_mask  flags_extra  ScriptName  VerifiedBuild
------  ------------------  ------------------  ------------------  -----------  -----------  --------  --------  --------  --------  --------------------  -------  --------  --------------  --------  --------  ------  -------  -------  ----------  ---------  ------  ------  ---------  --------------  ---------------  ------------  -------------  ----------  ----------  -----------  ------------  ------  ------------  -------------  -------------  ------------  ------  ----------  ------  --------------  --------  -----------  -----------  -----------  -----------  -----------  -----------  ------  ------  ------  ------  ------  ------  ------  ------  --------------  ---------  -------  -------  ------  ------------  -----------  -----------  --------------  ------------  -------------  --------------  ------------------  ------------  ----------  -----------  --------------------  -----------  ----------  -------------
  4727                   0                   0                   0            0            0      2764         0         0         0  Elder Thunder Lizard  (NULL)   (NULL)                 0        37        38       0       14        0           1    1.14286       1       0          0            2000             2000             1              1           1           0         2048             0       0             0              0              0             0       1           0    4727               0    100013            0            0            0            0            0            0    5401   20536   20535   20543       0       0       0       0               0          0        0        0                     1            1            1            1.15             1              1               1                   1             0           0            1                     0            0                      12340

name -> Elder Thunder Lizard

---

edit: D'oh. I failed to see your sarcasm, @lyn1337 (btw, I almost thought you were Norwegian or Danish because of the 'hæ?' in your comment.) 😆

[lyn1337]

@tkrokli My first name (Lyn) actually is Norwegian, but I do live in Germany and don't speak it or Fin much. (: Yep, I was only kidding. Not sure how spawning thunder lizards will help. 😄

[ghost]

OK, at least this time you got the NPC IDs right. Have to look at it later, got lots of other stuff going on.

[lyn1337]

@kizarr Kizarr, maybe you could share some thoughts about your approach and what you're trying to do.
It seems to me, you're spawning the prince and the king to the same pos with a different value for health? Your table structure looks different, too.

[ghost]

TrinityCore rev. 6007f2a 2016-06-02 00:31:32 +0200 (3.3.5 branch) (Win64, Release)
TDB 335.61 + updates up to and including 2016_06_01_12_world.sql '8DC7CF8'

SELECT * FROM `creature_template` WHERE `entry` IN (28907,29110);

 entry  modelid1  modelid2  modelid3  modelid4  name            subname  IconName  gossip_menu_id  minlevel  maxlevel     exp  faction  npcflag  speed_walk  speed_run   scale    rank  dmgschool  BaseAttackTime  RangeAttackTime  BaseVariance  RangeVariance  unit_class  unit_flags  unit_flags2  dynamicflags  family  trainer_type  trainer_spell  trainer_class  trainer_race    type  type_flags  lootid  pickpocketloot  skinloot  resistance1  resistance2  resistance3  resistance4  resistance5  resistance6  spell1  spell2  spell3  spell4  spell5  spell6  spell7  spell8  PetSpellDataId  VehicleId  mingold  maxgold  AIName   MovementType  InhabitType  HoverHeight  HealthModifier  ManaModifier  ArmorModifier  DamageModifier  ExperienceModifier  RacialLeader  movementId  RegenHealth  mechanic_immune_mask  flags_extra  ScriptName  VerifiedBuild
------  --------  --------  --------  --------  --------------  -------  --------  --------------  --------  --------  ------  -------  -------  ----------  ---------  ------  ------  ---------  --------------  ---------------  ------------  -------------  ----------  ----------  -----------  ------------  ------  ------------  -------------  -------------  ------------  ------  ----------  ------  --------------  --------  -----------  -----------  -----------  -----------  -----------  -----------  ------  ------  ------  ------  ------  ------  ------  ------  --------------  ---------  -------  -------  -------  ------------  -----------  -----------  --------------  ------------  -------------  --------------  ------------------  ------------  ----------  -----------  --------------------  -----------  ----------  ---------------
 28907     25514         0         0         0  Prince Valanar                                  0        72        72       2     2082        2           1    0.99206       1       1          0            2000             2000             1              1           1         768         2048             0       0             0              0              0             0       6          32       0               0         0            0            0            0            0            0            0       0       0       0       0       0       0       0       0               0          0        0        0  SmartAI             0            3            1               1             1              1             7.5                   1             0           0            1               8388624            0                      12340
 29110     24191         0         0         0  The Lich King                                   0        83        83       2     2100        2           1    1.14286       1       3          0            2000             2000             1              1           1         768         2048             0       0             0              0              0             0       6          36       0               0         0            0            0            0            0            0            0       0       0       0       0       0       0       0       0               0          0        0        0                      0            3            1            2000           500              1              35                   1             0         169            1               8388624            0                      12340

(columns difficulty_entry_1/2/3 + KillCredit1/2 removed for readability)

creature table, guid/id/name 130344/28907/Prince Valanar and 130896/29110/The Lich King:

SELECT * FROM `creature` WHERE `id` IN (28907,29110);

  guid      id     map  zoneId  areaId  spawnMask  phaseMask  modelid  equipment_id  position_x  position_y  position_z  orientation  spawntimesecs  spawndist  currentwaypoint  curhealth  curmana  MovementType  npcflag  unit_flags  dynamicflags  VerifiedBuild
------  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ---------------
130344   28907     609       0       0          1          4    25514             0     2316.65    -5738.61     155.981     0.733038            360          0                0       9610        0             0        0           0             0              0
130896   29110     609       0       0          1        192        0             0     2310.27    -5742.21     161.207      3.85718            360          0                0   27890000        0             0        0           0             0              0

current content in the creature table vs Kizarr's suggestion:

  guid      id     map  zoneId  areaId  spawnMask  phaseMask  modelid  equipment_id  position_x  position_y  position_z  orientation  spawntimesecs  spawndist  currentwaypoint  curhealth  curmana  MovementType  npcflag  unit_flags  dynamicflags  VerifiedBuild
------  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ---------------
130344   28907     609       0       0          1          4    25514             0     2316.65    -5738.61     155.981     0.733038            360          0                0       9610        0             0        0           0             0              0
130344   28907     609                          1          4        0             0     2316.65    -5738.61     155.981     0.733038            360          0                0       9610        0             0        0
------  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ---------------
130896   29110     609       0       0          1        192        0             0     2310.27    -5742.21     161.207      3.85718            360          0                0   27890000        0             0        0           0             0              0
130896   29110     609                          1        192        0             0     2310.27    -5742.21     161.207      3.85718            360          0                0   13945000        0             0        0
------  ------  ------  ------  ------  ---------  ---------  -------  ------------  ----------  ----------  ----------  -----------  -------------  ---------  ---------------  ---------  -------  ------------  -------  ----------  ------------  ---------------

There is not much change compared to TDB 335.61, except for 2 things:

• Prince Valanar's modelid has been removed
• The Lich King's hp has been reduced from 27 890 000 to 13 945 000

I see no reason to change the LK's hp, so only the modelid removal should be tested & explained.

[lyn1337]

I see no reason to change the LK's hp, so only the modelid removal should be tested & explained.

Not really… when the field modelid in table creature is set to 0, the core will just choose a random value, which isn't 0 from modelid1 to modelid4 in creature_template for it instead.
Entry 29110 (the king) also has no such model set in creature.

I think we might as well apply this:

-- remove unnecessarily set model id from Prince Valanar spawn
UPDATE `creature` SET `modelid`=0 WHERE `guid`=130344;

[ghost]

You are quite correct, Prince Valanar has got the default modelid1 = 25514 in creature_template.

---

edit: I don't know why it was set in the creature table when it exists in creature_template, it is not overriding anything as it is when the values are the same. I wonder if it makes any difference.
BTW, a better grammar in that comment sentence would be:

-- Scarlet Enclave: remove unnecessary model id  from Prince Valanar in the creature table
UPDATE `creature` SET `modelid` = 0 WHERE `guid` = 130344;

(although if anyone has got an explanation for why it needs to be there, I can withdraw the suggestion)

[Aokromes]

Again, hack, this comes from retail:

[9] GUID 2: Full: Type: Creature Entry: 28907 Low: 927
[9] Time: -1616821493
[9] Position: X: 2316.619 Y: -5742.296 Z: 155.9813

[ghost]

Z: 155.9813 ... interesting. Will have to check that later. lyn1337 - you will test that too?

[lyn1337]

Checked. Tried updating the spawn with the retail Z only and along with the retail X and Y plus updated Z in the SAI – he's on the ground again. 😞
Then again, why would Z be lower than FloorZ?

[ghost]

Good question, I would have thought that a higher Z coordinate would place him more correctly in height, but maybe there is something that I have misunderstood in the spawning process. Have you tried with a full 1.0 extra in the Z coordinate to see if anything useful happens?

[Aokromes]

Ingame npc info:
[22:39:44] Position: 2316.649902 -5738.609863 153.920074.
Maybe creature spawns before gameobject and because that it's moved to floor.
I have used .come tome and after move he climbs gameobject properly.

[ghost]

Yes, that is very likely. That used to be the common issue with any NPCs who sink into the ground.

---

The extreme opposite happens when NPCs are spawned after gameobjects and drop down on it.

[lyn1337]

@tkrokli & @Aokromes But if it was like that, sooner or later SAI would make him walk up onto it again.

The values from retail posted by Aokromes don't work here. (below FloorZ) This could be caused by the podium GO being some kind of lower on retail, so if we want to use this Z, we need sniffed values for the GO as well.
Both podium and Valanar have VerifiedBuild = 0.
…
which leads me into proposing this:

SET @z_ground := 153.920074; -- GroundZ
SET @z_floor := 156.12; -- FloorZ post GO repositioning
SET @valanar := 130344; -- Prince Valanar (entry: 28907) spawn
SET @podium := 66361; -- podium spawn (entry: 190919)

-- update spawn with sniffed retail values for X and Y and FloorZ value by gps command
UPDATE `creature` SET `position_x`=2316.619, `position_y`=-5742.296, `position_z`=@z_floor WHERE `guid`=@valanar;

-- update SAI movement with FloorZ value by gps command
UPDATE `smart_scripts` SET `target_z`=@z_floor WHERE `entryorguid`=2890700 and`id`=3;
UPDATE `smart_scripts` SET `target_z`=@z_floor WHERE `entryorguid`=2890700 and`id`=1;
UPDATE `smart_scripts` SET `target_z`=@z_floor WHERE `entryorguid`=2890700 and`id`=6;
UPDATE `smart_scripts` SET `target_z`=@z_floor WHERE `entryorguid`=2890700 and`id`=10;
UPDATE `smart_scripts` SET `target_z`=@z_floor WHERE `entryorguid`=2890700 and`id`=14;

-- update the podium gameobject with GroundZ value by gps command
UPDATE `gameobject` SET `position_z`=@z_ground WHERE `guid`=@podium;

-- Scarlet Enclave: remove unnecessary model id  from Prince Valanar in the creature table
UPDATE `creature` SET `modelid` = 0 WHERE `guid` =@valanar;

(Tested Query: Yes)

This is now fully working for me. I tried teleporting somewhere else and back again plus respawning Valanar.
And in case it should stop working, it can't be fixed by simply repositioning the creature or objects.

core_version: TrinityCore rev. 2d2544f 2016-06-03 17:57:05 +0200 (3.3.5 branch) (Unix, Release)
db_version: TDB 335.61

p.s. made a screenshot, but I think it's too dark.

[Aokromes]

GO coords:

[12] GUID: Full: Type: GameObject Entry: 190921 Low: 119
[12] Object Type: GameObject (5)
[12] Update Flags: StationaryObject, GORotation (576)
[12] Stationary Position: X: 2314.327 Y: -5740.21 Z: 153.9207

[lyn1337]

So the Z difference on retail is 2.0606 vs 2.199926 here. Tested, this doesn't work for me / us.
Did they change the GO model? 😆

[jackpoz]

The NPC is spawned at 155.981003, then SAI moves it around with MoveSplineInit::MoveTo() that calls path.CalculatePath(dest.x, dest.y, dest.z, forceDestination) that ignores spawned gameobjects.

_actualEndPosition = {x=2311.37988 y=-5740.14014 z=153.920074 }

What is still interesting is that when the height of each point in the path is updated with vmap data, it doesn't find the gameobject. This is caused by the creature being able to swim, calling GetWaterOrGroundLevel() with default phasemask 1 instead of the current creature phasemask

[lyn1337]

@jackpoz does this also cause the gps command to display wrong FloorZ at only certain points of the go?

[jackpoz]

Please try after 1347d7c , it seems to move around fine now to me

[lyn1337]

@jackpoz He appears sunken again. At least for me.

[ghost]

TrinityCore rev. 1347d7c 2016-06-04 15:01:39 +0200 (3.3.5 branch) (Win64, Release)
TDB 335.61 + updates up to and including 2016_06_02_01_world.sql (DBs rebuilt from scratch)

Started a new character, played it from creation to quest "The Will of the Lich King" (12714). At first, it looked like there was no change, so I thought "No, this can't be right with the new changes." and I exited the game, deleted my game client Cache folder and tried again. Looks a lot better :

I am tempted to say that 1347d7c has fixed the issue, but to be on the safe side, I would like to get confirmation from more users to see that this is not just a random event. 👍

[Killyana]

Once in this area try gm on/off and mod phase 4 many times and you will get this http://i.imgur.com/5rJ5iAO.jpg
Looks like if the npc is loaded before the gob on client side it will appear on the ground.
Even if the npc moves in this case, it will not be relocated on the top of the gob.

You can also reproduce the issue by just moving away from the npc to unload the grid, than return to it's position, do it many time and you will see sometimes it's on the ground sometimes not.

.gps executed on the npc as target:
1- .gps= X: 2316.649902 Y: -5738.609863 Z: 153.920074 Orientation: 0.733038 = http://i.imgur.com/LXPSHlJ.jpg
2- .gps= X: 2316.760010 Y: -5738.410156 Z: 156.024002 Orientation: 0.310998 = http://i.imgur.com/tt7R4er.jpg

[ghost]

OK, I see what you mean, so my experience is more or less just an opportune coincidence. I suppose I will have to test again with my game client addons loaded as well, just to see if they affect this too for me.

[lyn1337]

@Killyana He returns to the top of it for me. And the gps command returns incorrect FloorZ, even if he is.

[ghost]

Looks like I need to delete my game client Cache folder each time to make him appear on top of the GO.

---

edit: ... and it is just like you said, Killyana, it happens randomly when leaving the area and coming back.
(tested on rev. 30313fb 2016-06-04 19:31:29 +0100 (3.3.5 branch) (Win64, Release))

[Estaira]

Any progress on this yet?

[greenbagels]

TrinityCore rev. c2a36c9 2017-01-30 17:22:01 +0100 (3.3.5 branch) (Unix, Release, Static)
TDB 355.62 2016_10_17
Still getting this on a fresh build. Oddly enough, a simple relog (back to character screen and back in) while standing in front of the pedestal fixed the issue, at least for the Lich King in the later phase (who appeared nearly entirely inside the large pedestal).

[ghost]

Yes, the status is pretty much unchanged from when we discussed this on Jun 4, 2016.

[Killyana]

Cannot reproduce after e42903e

[offl]

https://youtu.be/5DMYXMDoQpI?t=31 on retail it's bugged too