Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Core/Quest: Alliancetoon get reputation for Hordefaction | Hordetoon get reputation for Alliancefaction #16582

Closed
Rushor opened this issue Feb 12, 2016 · 9 comments

Comments

@Rushor
Copy link
Contributor

Rushor commented Feb 12, 2016

Affected quests:
http://wowhead.com/?quest=11354
http://wowhead.com/?quest=11384
http://wowhead.com/?quest=11382
http://wowhead.com/?quest=11363
http://wowhead.com/?quest=11362
http://wowhead.com/?quest=11375
http://wowhead.com/?quest=11354
http://wowhead.com/?quest=11386
http://wowhead.com/?quest=11373
http://wowhead.com/?quest=11378
http://wowhead.com/?quest=11374
http://wowhead.com/?quest=11372
http://wowhead.com/?quest=11368
http://wowhead.com/?quest=11388
http://wowhead.com/?quest=11499
http://wowhead.com/?quest=11370

Upon completing these quests you will get some reputation:
350 reputation with The Consortium
350 reputation with Thrallmar
350 reputation with Honor Hold

Everything fine so far right? No WRONG!

The issue here is, that you will get as an alliance toon 350 reputation with Thrallmar (hordefaction) if you complete one of the quests and you are already exalted with Honor Hold (alliance faction).

How to reproduce:

  1. Get alliance toon
  2. Get exalted with Honor Hold
  3. complete one of the quests

Result: You will get reputation for the horde faction

Furthermore the issue also affects Hordetoons:
The issue here is, that you will get as an horde toon 350 reputation with Honor Hold (alliancefaction) if you complete one of the quests and you are already exalted with Trallmar (horde faction).

How to reproduce:

  1. Get horde toon
  2. Get exalted with Thrallmar
  3. complete one of the quests

Result: You will get reputation for the alliance faction

rev: 11d0b1d

@Rushor Rushor self-assigned this Feb 12, 2016
@TrinityCoreBot TrinityCoreBot added the Invalid-IncompleteData/OrNotTrinityCore Reporter deleted parts or all template or he is using a 3rd party unsupported core. label Feb 12, 2016
@Rushor Rushor removed the Invalid-IncompleteData/OrNotTrinityCore Reporter deleted parts or all template or he is using a 3rd party unsupported core. label Feb 12, 2016
@Shauren
Copy link
Member

Shauren commented Feb 12, 2016

is being exalted with honor hold a requirement?
does it also give you honor hold rep as horde if you are exalted with thrallmar?
is there another quest in db with the same name/text that maybe could be used for alliance instead (blizzard is known to duplicate quests just for reward changes and/or subtle text changes)

@Rushor
Copy link
Contributor Author

Rushor commented Feb 12, 2016

@Shauren:

is being exalted with honor hold a requirement?

It's required. If you are not exalted with honor hold, you will not get reputation to thrallmar.
If you are exalted with honor hold and keep completing the quest, you will get reputation for thrallmar as an alliance toon.

does it also give you honor hold rep as horde if you are exalted with thrallmar?

indeed, the same issue exists for the other faction. (i will update the titel and the description)

is there another quest in db with the same name/text that maybe could be used for alliance instead (blizzard is known to duplicate quests just for reward changes and/or subtle text changes)

sadly no, we could fix this with conditions then, but as already said, there is not another questentry

@Rushor Rushor changed the title [3.3.5] Core/Quest: Alliance get reputation for Horde [3.3.5] Core/Quest: Alliancetoon get reputation for Hordefaction | Hordetoon get reputation for Alliancefaction Feb 12, 2016
@Shauren
Copy link
Member

Shauren commented Feb 12, 2016

maybe its just the client that doesnt show you gaining reputation until exalted but you actually do?

@Rushor
Copy link
Contributor Author

Rushor commented Feb 12, 2016

maybe its just the client that doesnt show you gaining reputation until exalted but you actually do?

i actually get real reputation. furthermore the reputation gain will be added to you reputation list (pressing U)

@Shauren
Copy link
Member

Shauren commented Feb 12, 2016

i meant that you get thrallmar rep all the time even if not exalted with honor hold but the gain only shows in chat/scrolling text when exalted with honor hold

@Rushor
Copy link
Contributor Author

Rushor commented Feb 12, 2016

oh okay, well thats not the case
if it would be like that you would have a big reputation already if you reach the exalted point with the other faction

but for now it's like that:

  1. get exalted with honor hold (as alliance char)
  2. complete 1 quest
  3. get reputation for thrallmar -> reputation after first completion after beeing exaltet will be 350/xx (neutral).
    it doesn't matter how often you completed the quests before.
    the reputation will only be added first for the unfriendly faction if you are already exalted with the friendly faction

@ghost
Copy link

ghost commented Oct 10, 2016

Could these factions be added to reputation_spillover_template.faction and set all the following columns to 0 (zero) ? Or must it be fixed with changes in the core source?

@SnapperRy
Copy link
Contributor

Also happens with Honor Above All Else, though that does not require any exalted reputation.

Quest rewards 10 reputation to Alliance Vanguard, for BOTH Alliance and Horde characters.

Horde players will notice a gain of reputation with Frostborn (Alliance-only faction), because it is the only one of the factions linked to Alliance Vanguard that don't have FACTION_FLAG_INVISIBLE_FORCED set in DBC. Same with Hand of Vengeance for Alliance players (although I have yet to find a neutral/Alliance quest for them).

@Wyrserth
Copy link
Contributor

Wyrserth commented Jul 3, 2019

Solved both issues explained by Rushor and SnapperRy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants