[master] Rogue finishing moves will always only consume one combo point.

[mmorganj]

Description:
Rogue finishing moves only have one effect independent of combo points (cp)
Current behaviour: (Tell us what happens.)
Rogue finishing moves will consume and perform the effect of one cp regardless of the number of combo points the player has. Tested on rupture, eviscerate, envenom, run through.
Expected behaviour: (Tell us what should happen instead.)
If player has 5 cp and uses finishing move, 5 cp will be consumed and the effect determined by 5 cp will be performed. If the player has 4 cp and uses a finishing move 4 cp will be consumed and the 4 cp effect will occur. Etc.
Steps to reproduce the problem:

1. Choose Rogue class
2. Build combo points > 1.
3. Use any finishing move
4. CP will drop by 1 only. (5->4, 4->3, 3->2, etc.)
5. Effect of finishing move at 1 cp will occur.

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)
master
TC rev. hash/commit:
9b006e5
TDB version:
https://github.com/TrinityCore/TrinityCore/releases/tag/TDB703.00
Operating system:
windows 8.1

[matukaa]

Also, damage/duration calculation is incorrect for CP spenders. Not only for rogues but for druids as well

[Shauren]

That should be directly related to consuming 1 CP

[matukaa]

yea, sorry I didn't link it, I just wanted to mention that too :)

[ArcaneFox]

I don't know if it helps but Rupture and Kidney Shot is always consuming 1 CP but the duration is nearly* correct. (Tested with a level 40 character.)

Rupture example

http://www.wowhead.com/spell=1943/rupture

5 CP + Rupture = 20 sec (246 dmg)
4 CP + Rupture = 16 sec (246 dmg)
3 CP + Rupture = 12 sec (246 dmg)
2 CP + Rupture = 8 sec (246 dmg)
1 CP + Rupture = 4 sec (246 dmg)

*4 CP should be 20 sec; 3 CP should be 16 sec; etc