Kologarn arms issue

[BillytheOrc]

Description:
When the wipe happens to Kologarn, the arms should respawn only if dead.

Current behaviour:
Arms spawn no matter what when you die to Kologarn. This means if you wipe 5 times, you'll get 10 arms.

Expected behaviour:
When the wipe happens to Kologarn, the arms should respawn only if dead.

Steps to reproduce the problem:

1. Die to Kologarn.
2. Respawn
3. Die again
4. Tons of arms

Branch(es): 3.3.5

TrinityCore rev. 7fd8603+ 2017-11-16 18:35:58 +0100

TDB version: CHANGEME Version of the TrinityCore database
TDB 61

Operating system: Windows 10

[ghost]

@Keader - is this separate issue needed, or is it covered somewhere else?
@sirikfoll - is this something you will be looking into (boss_kologarn.cpp)?

[Keader]

Respawn issue fixed in 551d055

But he should despawn both arms when he die.

[Keader]

Try something like: https://gist.github.com/Keader/338f143ee38da560649c248c4a7de9c3

[Foereaper]

Tried with the above gist, had to add the following to the bottom of EnterEvadeMode for the arms to respawn correctly on a wipe:

Vehicle* vehicle = me->GetVehicleKit();
vehicle->InstallAccessory(NPC_LEFT_ARM, 0, true, TEMPSUMMON_MANUAL_DESPAWN, 0);
vehicle->InstallAccessory(NPC_RIGHT_ARM, 1, true, TEMPSUMMON_MANUAL_DESPAWN, 0);

New issue with said gist and above edit though, is on reset the right arm incorrectly spawns "rubble" that is only supposed to spawn on a player kill of said arm.

[Keader]

if i remember right, when he die with arms, should spawn rubble, but they get despawn...
btw, @sirikfoll has some fixes to kologarn (PR soon? xD), maybe he fix it together

[Shauren]

@Keader you mean after the fight is done? iirc that happens on retail but doesn't seem intended (they despawn very shortly after that)

[Foereaper]

After the fight is over seems to work perfectly after the above edits, the arms and the rubble despawn like it should, it's just the rubble not despawning after a wipe

[lachtanek]

Problem is the arms are not added to SummonList for some reason, so they don't despawn on wipe/death.
@Keader when overriding EnterEvadeMode of creature which is vehicle, you need to remember that Vehicle reset and AI reset methods are called in CreatureAI::EnterEvadeMode, so you need to call parent method or do this yourself. (very weird behavior imo that not all evade code is called in the underscored method, since it already exists for that reason)
This just shows that using underscored methods in AI is bad habits imo.

[lachtanek]

Just do something like this
https://gist.github.com/lachtanek/65ad0a2bb7210708b615a35cbf5e1dcb

[Foereaper]

Instead of all of the above edits or in addition to?

[lachtanek]

should work instead of what Keader posted

[Foereaper]

Alright, I'll test it as soon as I get home from work and will post back

[Foereaper]

Alrighty, tested the above edit, and while it seems to work where the arms are no longer double spawned on wipes, and no longer spawn adds when the raid wipes, another issue appears.

After said wipe, the arms are "resummoned" but they do not seem to actually do anything at all on the next attempt at the boss, almost as if they do not enter combat when the boss does and as if they are unlinked if that makes sense.

[lachtanek]

Weird, that functionality was not touched, I may take a look when I have time, I'm planning rewriting kologarn when I have time so I may as well post it here as PR, but not promising anything.

[Keader]

yeah @lachtanek #MakeUlduarGreat ~~~Again~~~ xD

Problem is the arms are not added to SummonList for some reason, so they don't despawn on wipe/death.
@Keader when overriding EnterEvadeMode of creature which is vehicle, you need to remember that Vehicle reset and AI reset methods are called in CreatureAI::EnterEvadeMode, so you need to call parent method or do this yourself. (very weird behavior imo that not all evade code is called in the underscored method, since it already exists for that reason)
This just shows that using underscored methods in AI is bad habits imo.

Good to know

@Keader you mean after the fight is done? iirc that happens on retail but doesn't seem intended (they despawn very shortly after that)

Yes, after fight is done
looks weird xD

[lachtanek]

@Keader I don't like the 'again' part, just #MakeUlduarGreat, or was it ever great on TC? :)

[Cyclone47]

With these changes it seems like after a wipe the raid becomes inaccessible. It seems like it does not properly close combat after a wipe.

Other then that, it works really well!

[ariel-]

Many arms! Handle it!

OT: The problem is not summonlist as this should be handled by vehicle accesories system instead of BossAI