Core/BG: Wintergrasp Rewrite m_tenacityStack should be signed int

[robinsch]

Description:

While debugging some WG I found out that m_tenacityStack should be signed. At https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Battlefield/Zones/BattlefieldWG.cpp#L1319 a negative value (in case alliance players have more people then horde) value gets assigned to a unsigned value causing overflow.

Branch(es):

both

TC rev. hash/commit:
da99183

[jackpoz]

WG is defined as "Experimental as in incomplete, bugged and with crashes".
There is currently a PR open about it #20144 with apparently the same issue, you could report the bug there and test the PR, maybe one day it will be merge :)

[lachtanek]

It should be fixed in the rewrite when ccrs gets to apply my submitted changes. He doesnt seem to have time for it right now tho.

[Faq]

Can someone change more describing title of issue, at-least put WG in it?