Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPELL_ATTR3_ONLY_TARGET_PLAYERS should get ignored at _ENTRY target types #21257

Open
Ovahlord opened this issue Jan 18, 2018 · 1 comment
Open

Comments

@Ovahlord
Copy link
Contributor

Description:
I just discovered a issue with SPELL_ATTR3_ONLY_TARGET_PLAYERS.
Spell ID - 74634 Ground Siege for example is suposed to deal damage to players only. This is the case for EFFECT_1 and EFFECT_2. But EFFECT_0 is a dummy effect that is suposed to hit a nearby entry. However. The target for that is an npc and the attribute blocks the selection for the npc. So as conclusion: the attribute should not get taken into account for targets that use _ENTRY target types.

Current behaviour:

SPELL_ATTR3_ONLY_TARGET_PLAYERS blocks xxx_ENTRY targeting.

Expected behaviour:

SPELL_ATTR3_ONLY_TARGET_PLAYERS should not affect target types that involve creature entries.

Steps to reproduce the problem:

  1. use this condition: https://paste2.org/BFteI9Hx
  2. spawn the target npc by using .npc add temp noloot 40030
  3. cast the spell by using .cast 74634 and see how the spell fails even if the target is right in front of you

Branch(es):
both

TC rev. hash/commit:
d1bd212

@Keader
Copy link
Member

Keader commented May 2, 2020

go fix it @Ovahlord sucker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants