[3.3.5] Shield Wall and Spell Reflection stay when remove shield

[Keader]

Description: After b8c281f warriors can use shield wall, equip again a 2 hand weapon and stay attacking (same of Spell Reflection)

Expected behaviour: If remove shield, reflection and shield wall should be removed. But need stay when affected by Dismantle

Steps to reproduce the problem:

1. Cast Shield Wall / Spell Reflection
2. Unequip shield

Branch(es): 3.3.5

TC rev. hash/commit: a891eb3

Introduced trying fix #19782

[ariel-]

Not true #19782

Also there are guides suggesting you can use Shield Wall and switch to two hander.

[Jildor]

hmmmm I think this is not entirely true.
I see those comments:
https://www.wowhead.com/spell=871/shield-wall#comments:id=1644461

So I noticed a nice perk of playing Fury in PvP. Normally in PvP when a warrior has to go defensive, he sacrifices damage because you need to keep your shield on in order to shield wall. However, this is not the case if you use a basic /equipslot 17 Offhand macro. You can pop on your shield, activate shield wall, then swap right back to your offhanded weapon and keep the buff! A wonderful trick for not falling into a vicious cycle of getting outpressured.

This seems to have been fixed in MoP. Unequipped your shield now cancels Shield Wall. :( Shame really. You can get around this by putting the /equipslot 17 Offhand macro on your Wild Strike or Raging Blow. Or both.

https://www.mmo-champion.com/threads/718296-Fury-Shield-Wall-Macro-Help

From my understanding (could be very wrong) shield wall continues even after swapping back to a off hand weapon so I was after a macro that does the sequence all in one.
Thanks for the response i'll try those out and maybe end up using 2 different macros.

https://www.mmo-champion.com/threads/861781-Shield-wall-without-shield

So basically, you use shield wall and equip back into dual wielding 2 weapons (SMF/TG) and you keep the shield wall buff
However, if you do it as arms and only equip 1 weapon without swapping out shield with anything in that slot you lose the shield wall buff

Somewhere along these lines there has to be a bug? Becaus ehonestly, if this was intended it would surely fit arms about 100x better wouldnt it...?

So, I think in Wotlk when you have Shield Wall aura and switch you shield with a weapon (fury warrior titan's grip) you should keep Shield Wall Aura
But if you remove our shield switching to two-hand weapon (without Titan's grip) you should lose the Shield Wall aura?

[Jildor]

More evidences:

https://www.youtube.com/watch?v=H4K8puGa1vs

https://www.ownedcore.com/forums/world-of-warcraft/world-of-warcraft-exploits/218239-shield-wall-2h-weps.html

https://www.youtube.com/watch?v=EwLOcI4h_kg&t=1624 <--- 17:35 get Shield Wall and before expires the aura, he lose it

https://www.youtube.com/watch?v=EwLOcI4h_kg&t=1624 <-- 27:04

So, this bug only happens in Wotlk with the Titan's Grip talent
If the warrior doesn't have this talent, he lose the auras that requires shield when he unequip the shield

[V3nomAnc3r]

Confirmed on rev ebea1bf

[V3nomAnc3r]

can some one fix this issue please!