Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks of the Valiant/Champion are not awarded if the Valiant/Champion was finished off with Charge #22251

Open
Nocty1501 opened this issue Aug 11, 2018 · 3 comments

Comments

@Nocty1501
Copy link

Description:

Ending the fight with a Valiant or Champion at the Argent Tournament via Charge will not earn the player a Mark of the Champion or Mark of the Valiant.

Current behaviour:

As above.

Expected behaviour:

A Mark of the Valiant/Mark of the Champion should be awarded as normal.

Steps to reproduce the problem:

  1. .quest add 13790
  2. Mount up, fight a Champion
  3. Make sure to deal the "killing blow" with Charge

Branch(es):

3.3.5

TC rev. hash/commit:

TrinityCore rev. 038ad52+ 2018-08-11 03:16:41 +0000 (3.3.5 branch) (Unix, RelWithDebInfo, Static)

Operating system:

Ubuntu 18.04

@Aokromes
Copy link
Member

update your core to at least 3f7ad3b.

@Nocty1501
Copy link
Author

Nocty1501 commented Aug 11, 2018

I did git pull origin 3.3.5 literally 30 minutes ago.

Edit: Doubt Rochet's transmogs would affect this.

@Killyana
Copy link
Member

Killyana commented Aug 11, 2018

Yes looks broken again, it was fixed mounths ago, but on the current version it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants