-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3.5] Core/Spells: Vampiric Touch and Unstable Affliction (dispel effect) shouldn't ignore resilience #22270
Comments
Yep, I know those issues @Keader, the issue is real, what is the problem? 😄 |
@Jildor He's referencing the issues so they all come under one title. |
Can you apply patch below and re-test? |
Confirmed on c76931c |
@Langerz82 , fix don't work and have crash |
@xvwyh, can you comment this spell? |
The reason they ignore resilience is obvious: // Spells with SPELL_ATTR4_FIXED_DAMAGE ignore resilience because their damage is based off another spell's damage.
if (!spellInfo->HasAttribute(SPELL_ATTR4_FIXED_DAMAGE))
{ Resilience is ignored if spell has // Vampiric Touch (dispel effect)
ApplySpellFix({ 64085 }, [](SpellInfo* spellInfo)
{
// copy from similar effect of Unstable Affliction (31117)
spellInfo->AttributesEx4 |= SPELL_ATTR4_FIXED_DAMAGE;
spellInfo->AttributesEx6 |= SPELL_ATTR6_LIMIT_PCT_DAMAGE_MODS;
}); If those spells (Unstable Affliction primarily, as the code in SpellMgr.cpp is a hack and shouldn't be considered blizzlike behavior) should be affected by resilience, then you need to reevaluate whether the condition in |
@jackpoz , after the great fix gargoyles, you can check vampiric touch?) |
You can start by doing the research explained above |
The obvious issue here is that it using fixed damage needs to only happen on the dispel effect - otherwise the damage applied from dispelling double dips on resilience, making this dot a non-threat while it should be. If you want the expected damage on a target with no magic resistance, just take the tooltip value and apply resilience to it. |
Ops xD 17k Dmg when i Cleanse (vampiric touch) resil 1500 |
Description:
ID - 64085 Vampiric Touch (dispel effect)
ID - 31117 Unstable Affliction (dispel effect)
Those spells shouldn't ignore resilience
Seems this @ariel- commit doesn't work: 3753ec5
Steps to reproduce the problem:
Branch(es):
3.3.5
TC rev. hash/commit:
The text was updated successfully, but these errors were encountered: